Paths

Table of Contentst

Differential D7696

.WRL imports without material fix
Needs RevisionPublic
Actions

Authored by Adam (adammak) on May 11 2020, 11:05 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Maniphest Tasks

T71232: X3D Import does not handle Materials

Summary

Small changes fixing material import from .wrl files

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Adam (adammak) requested review of this revision.May 11 2020, 11:05 PM

Adam (adammak) created this revision.

Ankit Meel (ankitm) added a task: T71232: X3D Import does not handle Materials.May 12 2020, 9:02 AM

Ankit Meel (ankitm) added a reviewer: Campbell Barton (campbellbarton).May 12 2020, 9:05 AM

Ankit Meel (ankitm) edited projects, added Add-ons (Community); removed BF Blender (2.82).

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).May 12 2020, 9:28 AM

Philipp Oeser (lichtwerk) added inline comments.

io_scene_x3d/import_x3d.py
1296	why was this changed?
2705	codestyle: please add spaces diff_color = diff_color + [1]
2715	looks like these properties are not supported anymore? If this fixes an error (or just doesnt make sense anymore), really remove this [not just comment out] and explain this in the Diff summary
2720	same as above

Removing old, unsupported properties from material creation

Since before it was return # XXX For now... I see no problem with this change.
But for review it might be good to explain why 'emissiveColor' and 'shininess' cannot be implemented. And why 'transparency' was commented.

Bastien Montagne (mont29) requested changes to this revision.May 27 2020, 6:18 PM

Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Bastien Montagne (mont29) added inline comments.

io_scene_x3d/import_x3d.py
2705	This is useless, this property is totally unused by current renderers.
2707–2710	Those should be commented out, with comment that we do not support those for now.
2712–2713	This should be kept, we have `specular_intensity`
2714–2719	Commented out with comments about why, as above

This revision now requires changes to proceed.May 27 2020, 6:18 PM

Philipp Oeser (lichtwerk) mentioned this in T81519: Trouble importing and exporting vrml files.Oct 8 2020, 10:45 AM

Max Schlecht (Bobbe) added a subscriber: Max Schlecht (Bobbe).Sep 4 2021, 6:16 PM

Max Schlecht (Bobbe) mentioned this in D12399: Fix T71232: .X3D/.WRL imports without materials and textures.Sep 4 2021, 6:49 PM

Revision Contents
Changeset List

Path

Size

io_scene_x3d/

33 lines

Diff 24641

io_scene_x3d/import_x3d.py

Loading...