Page MenuHome
Differential D769

Simplification in traversal code
AbandonedPublic
Actions

Authored by Thomas Dinges (dingto) on Aug 31 2014, 3:31 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Bao 2 (bao2)
Summary

Simplification of the traversal code

Diff Detail

Event Timeline

Bao 2 (bao2) updated this revision to Diff 2512.Aug 31 2014, 3:31 PM
Bao 2 (bao2) retitled this revision from to Simplification in traversal code.
Bao 2 (bao2) updated this object.
Bao 2 (bao2) added a comment.Aug 31 2014, 3:36 PM

This is for T41658
https://developer.blender.org/T41658

Thomas Dinges (dingto) added reviewers: Sergey Sharybin (sergey), Thomas Dinges (dingto).Aug 31 2014, 3:50 PM
Thomas Dinges (dingto) added projects: BF Blender, Cycles.
Bao 2 (bao2) added a comment.Sep 1 2014, 2:41 AM

Another correction:
DingTo, look at line 143 in this file:
https://developer.blender.org/diffusion/B/browse/master/intern/cycles/kernel/geom/geom_bvh_traversal.h

and you see float_as_uint() is used:
traverseChild0 = (c0max >= c0min) && (float_as_uint(cnodes.z) & visibility);

So in lines 129, 133, 174 and 178
it must be also float_as_uint() and no float_as_int()

Bao 2 (bao2) added a comment.Sep 1 2014, 3:04 AM
This comment was removed by Bao 2 (bao2).
Bao 2 (bao2) added a comment.Sep 1 2014, 12:04 PM
This comment was removed by Bao 2 (bao2).
Bao 2 (bao2) added a comment.Sep 1 2014, 12:15 PM
This comment was removed by Bao 2 (bao2).
Bao 2 (bao2) added a comment.Sep 1 2014, 12:54 PM
This comment was removed by Bao 2 (bao2).
Thomas Dinges (dingto) commandeered this revision.Sep 5 2014, 4:25 AM
Thomas Dinges (dingto) abandoned this revision.
Thomas Dinges (dingto) edited reviewers, added: Bao 2 (bao2); removed: Thomas Dinges (dingto).

Closing on request of bao2.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
geom/
9 lines
9 lines
9 lines
util/
13 lines

Diff 2512

View Options

intern/cycles/kernel/geom/geom_bvh_shadow.h

Loading...
View Options

intern/cycles/kernel/geom/geom_bvh_subsurface.h

Loading...
View Options

intern/cycles/kernel/geom/geom_bvh_traversal.h

Loading...
View Options

intern/cycles/util/util_ssef.h

Loading...