Page MenuHome

Fix T75908: Sculpt GPU Batches + Render Artifacts
ClosedPublic

Authored by Jeroen Bakker (jbakker) on May 12 2020, 11:37 AM.

Details

Summary

When sculpting the GPU batches are constructed with only the needed data
for a single viewport. When that viewport changes shading or coloring mode (object
to vertex) batches might not hold all the needed information.

There is also a case when you have two 3d viewport one in object color
mode and the other in vertex color mode that the GPU batches were
updated without any vertex colors.

In order to fix these category of issues this patch would always
construct the full GPU batches for sculpting.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.May 12 2020, 11:37 AM
Jeroen Bakker (jbakker) retitled this revision from Fix Rendering Glitches During Sculpting to Fix T75908: Rendering Glitches During Sculpting.May 12 2020, 11:41 AM
Jeroen Bakker (jbakker) retitled this revision from Fix T75908: Rendering Glitches During Sculpting to Fix T75908: Rendering Glitches When Switching Shading During a SculptSession.
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Won't this have a significant performance impact when switching modes?

I see now it's only for sculpt objects. I guess that's not so bad. But maybe the tagging can be avoided when switching between modes with compatible batches?

Maybe switching between wireframe and solid, or material preview and rendered doesn't require any changes.

Jeroen Bakker (jbakker) planned changes to this revision.May 12 2020, 4:57 PM

I think the best fix would be to always include the vcol in the sculpt batches.
current fix doesn't work with 2 active views open. one requesting sculpt batch without vcols and the other requesting sculpt batches with vcols.
Hmm... redoing this.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Different approach always generate full GPU buffers during sculpting

Jeroen Bakker (jbakker) retitled this revision from Fix T75908: Rendering Glitches When Switching Shading During a SculptSession to Fix T75908: Sculpt GPU Batches + Render Artifacts.May 12 2020, 6:41 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 13 2020, 5:45 PM