Fix selected_nla_strips when used in other editors
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 12 2020, 1:06 PM.

Details

Reviewers

Philipp Oeser (lichtwerk)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T76669: Dope Sheet Editor, crash right clicking on a Mask channel

Commits

rBe5bb02aaa416: Fix T76669: Crash when doing right click on channel

Summary

This was introduced in rBf8c4f5e308.

I detected this with ASAN. There was a heap buffer overflow when I
right-clicked on a channel in the timeline.

Please check if the original if the thing you fixed in rB60ff3a7daff75e631993e6e5d284746442e824f3 still works for you.

Diff Detail

Repository

rB Blender

Branch

selected-nla-strips-fix (branched from master)

Build Status

Buildable 8009
Build 8009: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.May 12 2020, 1:06 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B8009: Diff 24667.May 12 2020, 1:06 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)May 12 2020, 1:07 PM

Philipp Oeser (lichtwerk) added a task: T76669: Dope Sheet Editor, crash right clicking on a Mask channel.May 12 2020, 1:15 PM

Philipp Oeser (lichtwerk) mentioned this in T76669: Dope Sheet Editor, crash right clicking on a Mask channel.

This also seems to work, thx for this! Just waiting for @Sybren A. Stüvel (sybren) to comment in T76669: Dope Sheet Editor, crash right clicking on a Mask channel

Ok, will wait with committing this until you accept it. :)

I do wonder if ANIM_animdata_filter could filter this for us already, but I'm not sure if that is supported.

I don't think it's possible to let ANIM_animdata_filter() only return elements of a specific type, so the current approach looks good to me.
I haven't actually tested the code, I trust @Jacques Lucke (JacquesLucke) and @Philipp Oeser (lichtwerk) on this ;-)

This revision is now accepted and ready to land.May 12 2020, 1:37 PM

Closed by commit rBe5bb02aaa416: Fix T76669: Crash when doing right click on channel (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMay 12 2020, 2:48 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBe5bb02aaa416: Fix T76669: Crash when doing right click on channel.