Differential D7704

Fix T74694: Sculpt Mask Influences Weight/Vertex Paint Drawing
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on May 12 2020, 2:06 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T74694: Vertex and weight paint mode broken after using sculpt mode mask tools

Commits

rBbe4b3c64ad76: Fix T74694: Sculpt Mask Influences Weight/Vertex Paint Drawing

Summary

Sculpt overlay assumed that the sculpt session was always in sculpt
mode. But the sculpt session was also used for Vertex/Weight painting.
This resulted that when a mask was defined in the sculpt mode this
resulted into render artifacts.

This patch adds a check to see if the object has a sculpt session for
OB_MODE_SCULPT.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.May 12 2020, 2:06 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B8012: Diff 24676.May 12 2020, 2:06 PM

Jeroen Bakker (jbakker) retitled this revision from Cleanup: Remove print statement to Fix T74694: Sculpt Mask Influences Weight/Vertex Paint Drawing.May 12 2020, 2:08 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Forgot import.
Rebased to remove local commit

Harbormaster completed remote builds in B8013: Diff 24677.May 12 2020, 2:12 PM

Jeroen Bakker (jbakker) updated this revision to Diff 24678.May 12 2020, 2:14 PM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a project: GPU / Viewport.

Clément Foucault (fclem) accepted this revision.May 12 2020, 3:13 PM

This revision is now accepted and ready to land.May 12 2020, 3:13 PM

Closed by commit rBbe4b3c64ad76: Fix T74694: Sculpt Mask Influences Weight/Vertex Paint Drawing (authored by Jeroen Bakker (jbakker)). · Explain WhyMay 12 2020, 4:22 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBbe4b3c64ad76: Fix T74694: Sculpt Mask Influences Weight/Vertex Paint Drawing.