Fix T76698: Movie clip stabilize display ignore footage colorspace settings
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 12 2020, 11:35 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T76698: Movie clip stabilize display ignore footage colorspace settings

Commits

rBabcb23f5a3b6: Fix T76698: Movie clip stabilize display ignore footage colorspace

Summary

Stabilized ImBuf just needs to use the same colorspace as the original
one.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.May 12 2020, 11:35 PM

Harbormaster completed remote builds in B8025: Diff 24704.May 12 2020, 11:35 PM

Philipp Oeser (lichtwerk) requested review of this revision.May 12 2020, 11:35 PM

Think you need to do the same for float buffer color space. Also, alpha mode needs to be copied.

Maybe add IMB_colormanagegent_copy_settings() or similar name and have assignment of all color space and alpha mode related settings in there.

also do for float buffer color space and alpha flags (not 100% sure this is really neccessary)
I have left IMB_colormanagegent_copy_settings for later (not sure where this would be used elsewhere)

Harbormaster completed remote builds in B8048: Diff 24773.May 14 2020, 5:16 PM

Even if the code is not currently seen to be used elsewhere it still worth localizing functionality in a function. One function one meaning, can't beat clarity of that.
It also makes it so if such functionality is needed elsewhere it's easy to find such function.