Details

Reviewers

Summary

This patch uses gzip's API to avoid writing uncompressed, then compressing.

Note that I dont really like passing both the gzip file handle and the regular file handle, but its only to a few functions, so its not that bad.

Diff Detail

Event Timeline

Campbell Barton (campbellbarton) updated this revision to Diff 2525.Sep 3 2014, 3:08 PM

Campbell Barton (campbellbarton) retitled this revision from to Writes a GZip file directly (instead of writing, then compressing).

Campbell Barton (campbellbarton) updated this object.

Campbell Barton (campbellbarton) added a reviewer: Sergey Sharybin (sergey).

Campbell Barton (campbellbarton) set the repository for this revision to rB Blender.

Campbell Barton (campbellbarton) added a project: BF Blender.

I agree with your comment about the filehandles being not super pretty but to me this makes so much sense that I just end up wondering why we ever did it the other way around. :)

Maverick (maverick) added a subscriber: Maverick (maverick).Sep 3 2014, 4:15 PM

Save our SSDs, trunk !

Campbell Barton (campbellbarton) updated this revision to Diff 2529.Sep 4 2014, 12:17 PM

Sergey Sharybin (sergey) added inline comments.Sep 4 2014, 12:27 PM

source/blender/blenloader/intern/writefile.c
204	Ideally storage should be more generic as well. It'll be stupid to store all the handles needed for any compression algo here. Could be either void* and INT_AS_PTR magic, or just structs like we've got in modifiers. Or just void* to own allocated struct.
211	Personally i'd just inline this `(wc)->user_data.file_handle`, don't see huge benefit of doing macro stuff here.
268	That's not create, that's init. Create is associating with allocating something or so.