UI: Graph Editor: Draw Handles Lines With Smoothing
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 15 2020, 4:06 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

Summary

Enabling "Use High Quality Display" in the graph editor currently enables AA for the curves, but the handles are still ugly.

With smoothing they look a lot better and fit in better with the rest of the UI.

Before	After

This also makes the handle lines slightly thicker, which I see as a benefit as well.

I may be missing something, but this seems like a simple quick fix for an oversight.

Repository

rB Blender

Branch

graph-handle-smooth (branched from master)

Build Status

Buildable 8067
Build 8067: arc lint + arc unit

source/blender/editors/space_graph/graph_draw.c
346	The added lines mirror code elsewhere in the file, although I got the same results without `GPU_blend(true);` on the default theme.

source/blender/editors/space_graph/graph_draw.c
346–349	Line smooth and blend should be disabled again at the end of the function, as is done in other places in this file.

This revision now requires changes to proceed.May 15 2020, 4:35 PM

source/blender/editors/space_graph/graph_draw.c
346	Note the code that calls this function is: GPU_blend(true); draw_fcurve_handles(sipo, fcu); GPU_blend(false); Removing the `GPU_blend` there and moving it into this function seems more consistent to me.