Differential D7744

Fix T76772: Addon: Add Camera Rigs are broken
ClosedPublic
Actions

Authored by Demeter Dzadik (Mets) on May 15 2020, 1:08 PM.

Details

Reviewers

Julian Eisel (Severin)

Maniphest Tasks

T76772: Addon: Add Camera Rigs are broken

Commits

rBA93a8e7eaca43: Fix T76772: Add Camera Rigs - broken constraint default

Summary

First time submitting a patch for the addons repo, let me know if I did it right.

As pointed out in the comments of the task (T76772#932038) this was caused by the changes to the Track To defaults, so I added @Julian Eisel (Severin) as reviewer for this as punishment.

On a side note: I checked all other cases of "TRACK_TO" in the addons repo to see if there are any other addons that might have this issue, but in all other cases, the track axis and up axis are always specified after creating the constraint. Lucky!

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.May 15 2020, 1:08 PM

Demeter Dzadik (Mets) created this revision.

Demeter Dzadik (Mets) edited the summary of this revision. (Show Details)May 15 2020, 1:10 PM

Demeter Dzadik (Mets) added a task: T76772: Addon: Add Camera Rigs are broken.

I generally deserve any punishment, no worries!

Scripts should generally avoid relying on defaults, for precisely this reason.
Double checked and indeed, I can't find any bundled add-ons that need fixing either.

This revision is now accepted and ready to land.May 15 2020, 3:12 PM

Closed by commit rBA93a8e7eaca43: Fix T76772: Add Camera Rigs - broken constraint default (authored by Demeter Dzadik (Mets), committed by Julian Eisel (Severin)). · Explain WhyMay 15 2020, 3:13 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rBA93a8e7eaca43: Fix T76772: Add Camera Rigs - broken constraint default.