Page MenuHome
Differential D7768

VSE UI: Text Strip, new default values and use percentage and sliders
AbandonedPublic
Actions

Authored by Peter Fog (tintwotin) on May 18 2020, 12:29 PM.

Details

Reviewers
William Reynish (billreynish)
Richard Antalik (ISS)
Eitan Traurig (EitanSomething)
Summary

Change Location and Wrap values from 0.0 -> 1.0 to 0.00% -> 100.00%

Before:

After:

Added new default values, which will center the text, make it larger and and add a wrap value of 70%.

Before:

After:

Diff Detail

Repository
rB Blender

Event Timeline

Peter Fog (tintwotin) requested review of this revision.May 18 2020, 12:29 PM
Peter Fog (tintwotin) created this revision.
Peter Fog (tintwotin) retitled this revision from VSE UI: Use percentage and sliders instead of 0.0 -> 1.0 values to VSE UI: Use percentage and sliders instead of 0.0 -> 1.0 values for Location and Wrap Width in Text Strips.May 18 2020, 8:50 PM
Peter Fog (tintwotin) updated this revision to Diff 24941.May 19 2020, 8:48 PM
Peter Fog (tintwotin) retitled this revision from VSE UI: Use percentage and sliders instead of 0.0 -> 1.0 values for Location and Wrap Width in Text Strips to VSE UI: Text Strip, new default values and use percentage and sliders.
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)
Peter Fog (tintwotin) added reviewers: William Reynish (billreynish), Richard Antalik (ISS).

Added new default values, which will center the text, make it larger and and add a wrap value of 70%.

Before:

After:

Peter Fog (tintwotin) mentioned this in D7714: VSE: Text strip defaults set to BBC subtitle standards.May 19 2020, 8:50 PM
Pablo Vazquez (pablovazquez) awarded a token.May 20 2020, 3:20 PM
Hans Goudey (HooglyBoogly) awarded a token.May 20 2020, 4:00 PM
Richard Antalik (ISS) requested changes to this revision.May 20 2020, 4:07 PM

I think this would be OK change, but there need to be versioning code. This would break old files.

source/blender/blenkernel/intern/seqeffects.c
3799

Should be 70.0f since wrap_width is float

3923

Should be 0.0f since wrap_width is float

This revision now requires changes to proceed.May 20 2020, 4:07 PM
Andrea Monzini (Andrea_Monzini) awarded a token.May 24 2020, 2:32 PM
Andrea Monzini (Andrea_Monzini) added a subscriber: Andrea Monzini (Andrea_Monzini).
Peter Fog (tintwotin) abandoned this revision.Jun 8 2020, 3:12 PM
Eitan Traurig (EitanSomething) commandeered this revision.Jun 8 2020, 3:32 PM
Eitan Traurig (EitanSomething) reclaimed this revision.
Eitan Traurig (EitanSomething) added a reviewer: Peter Fog (tintwotin).
This revision now requires changes to proceed.Jun 8 2020, 3:32 PM
Eitan Traurig (EitanSomething) updated this revision to Diff 25645.Jun 8 2020, 7:04 PM
  • Fix float issue
Eitan Traurig (EitanSomething) added a comment.Jun 8 2020, 7:06 PM

I don't know how to do the versioning @Richard Antalik (ISS) can you do it

Peter Fog (tintwotin) mentioned this in D8393: Media transform redesign.Sep 15 2020, 10:06 AM
Peter Fog (tintwotin) added a project: VFX & Video.Sep 22 2020, 8:14 AM
Peter Fog (tintwotin) mentioned this in D9468: Add background rectangle option to video sequencer Text strip.Nov 7 2020, 12:20 PM
Peter Fog (tintwotin) mentioned this in D10542: VSE: Add bold and italic.Feb 26 2021, 9:41 AM
Peter Fog (tintwotin) commandeered this revision.Feb 26 2021, 1:40 PM
Peter Fog (tintwotin) edited reviewers, added: Eitan Traurig (EitanSomething); removed: Peter Fog (tintwotin).
Peter Fog (tintwotin) mentioned this in D10571: VSE: Text strip preset tweaks.Mar 1 2021, 7:21 PM
Peter Fog (tintwotin) abandoned this revision.Apr 13 2021, 1:11 PM

This patch didn't make it into 2.93. As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this patch for now.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
14 lines
makesrna/
intern/
8 lines

Diff 25645

View Options

source/blender/blenkernel/intern/seqeffects.c

Loading...
View Options

source/blender/makesrna/intern/rna_sequencer.c

Loading...