Transform: Replace View3d Snap operators with a transform ops version
Needs RevisionPublic
Actions

Authored by Germano Cavalcante (mano-wii) on May 18 2020, 7:10 PM.

Details

Reviewers

Summary

All view3d.snap_ operators have a logic very similar to transform.translate.
It is basically moving specific objects to a chosen destination.
Because of this similar logic, there is a lot of similar or duplicate code between these operators.
Also, with each new feature implemented for transform, the user expects a corresponding behavior for view3d.snap_ (eg. T73400)

This patch proposes to remove all view3d.snap_ operators and use a corresponding one with the transform system.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D7780 (branched from master)

Build Status

Buildable 16788
Build 16788: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.May 18 2020, 7:10 PM

Harbormaster completed remote builds in B8102: Diff 24884.May 18 2020, 7:10 PM

Germano Cavalcante (mano-wii) requested review of this revision.May 18 2020, 7:10 PM

noki paike (amonpaike) awarded a token.May 20 2020, 11:51 AM

Germano Cavalcante (mano-wii) mentioned this in D4897: Fix T63470: Snap Selection to Cursor does not respect cursor rotation.Apr 23 2021, 4:19 PM

Rebase onto master

Harbormaster completed remote builds in B16775: Diff 41366.Sep 2 2021, 2:43 PM

Example of a file whose "Select to Cursor" does not work with this patch:

Bug_ChildOf_Selection2Cursor.blend838 KBDownload

Fix Select to Cursor with constraints
Rename

Harbormaster completed remote builds in B16788: Diff 41386.Sep 2 2021, 9:22 PM

Germano Cavalcante (mano-wii) mentioned this in T91079: Bug when working with the Child Of constraint and the Selection to Cursor command.Sep 2 2021, 9:26 PM

Generally good to reduce duplicate code:

It would be good to have UV snapping use this too (to make sure the logic here is generic and to further de-duplicate logic).
... possible f-curve too, although some of these snap operations don't map directly to transform logic as the 3d-view and UV-editor does.