In D7786#187755, @Sergey Sharybin (sergey) wrote:

Think its fine but a bit weird to do DEG_id_tag_update since the mask was transformed, so should have been tagged somewhere for that already?

I can only assume this is how the transform system works?

you change data (mouse move etc), you get recalcData / recalcData_mask_common [that tags indeed]
but if you confirm, you are not really changing data again [unless you are auto-keyframing mask which will store the points in the shape]

And inbetween that recalcData and the confirm, depsgraph ran once?

Evan Wilson (EAW) added a project: VFX & Video.May 19 2020, 4:45 PM

@Sergey Sharybin (sergey): anything more to check?

Think it's fine. There are other special cases in special_aftertrans_update which does DEG tag as well, so seems this is indeed how it's supposed to be.

This revision is now accepted and ready to land.May 25 2020, 11:22 AM

Closed by commit rBa8a6b3627af4: Fix autokeyframing masks not updating properly (authored by Philipp Oeser (lichtwerk)). · Explain WhyMay 25 2020, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBa8a6b3627af4: Fix autokeyframing masks not updating properly.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_convert.c

5 lines

Diff 24913

View Options

source/blender/editors/transform/transform_convert.c

Fix autokeyframing masks not updating properlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24913

source/blender/editors/transform/transform_convert.c

Fix autokeyframing masks not updating properly
ClosedPublic
Actions

Revision Contents
Changeset List