Fix T75197: Eevee does not render instanced smoke
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 20 2020, 1:45 PM.

Details

Reviewers

Sebastián Barschkis (sebbas)
Clément Foucault (fclem)

Maniphest Tasks

T75197: Eevee doesn't show smoke from a linked collection (Cycles does)

Commits

rB8fe448b44d1d: Fix T75197: Eevee does not render instanced smoke

Summary

I'm not sure if there was a good reason for this check. I could not find the reason in the commit history.
In my simple test this patch solved the issue perfectly.

eevee_instanced_smoke.blend610 KBDownload

Before:

After:

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.May 20 2020, 1:45 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B8132: Diff 24954.May 20 2020, 1:45 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)May 20 2020, 1:49 PM

Jacques Lucke (JacquesLucke) added reviewers: Sebastián Barschkis (sebbas), Clément Foucault (fclem).May 20 2020, 2:09 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added a task: T75197: Eevee doesn't show smoke from a linked collection (Cycles does).

Seems fine to me, but don't have an explanation for the check either.

I have no idea why this check was needed. Maybe someone with more experience can explain? @Brecht Van Lommel (brecht) @Sergey Sharybin (sergey) ?

This revision is now accepted and ready to land.May 20 2020, 4:44 PM

This was added in rBc8005703f298: Fix T46420: Segfault when instancing smoke domain., but it's not needed anymore in the new draw manager.

workbench_cache_populate also has the same BASE_FROM_DUPLI test, can that be removed as well?

Closed by commit rB8fe448b44d1d: Fix T75197: Eevee does not render instanced smoke (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMay 20 2020, 4:57 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB8fe448b44d1d: Fix T75197: Eevee does not render instanced smoke.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

eevee/

eevee_volumes.c

3 lines

Diff 24964

View Options

source/blender/draw/engines/eevee/eevee_volumes.c

Fix T75197: Eevee does not render instanced smokeClosedPublicActions