Differential D7800

Fix T74443: No render in VP9 lossless mode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 20 2020, 2:09 PM.

Tags

None

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)
Richard Antalik (ISS)

Maniphest Tasks

T74443: No render in VP9 lossless mode

Commits

rB98689f51c011: Fix T74443: No render in VP9 lossless mode

Summary

We define Lossless as CRF 0 (which is usually the best quality and is
working fine with other codecs afaict), but since WebM only allows for
CRF values between 2-32 and actually has a dedicated "lossless" mode, I
suggest using that (it produces large files though, so double-checking
would be welcome).

https://trac.ffmpeg.org/wiki/Encode/VP9#LosslessVP9

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.May 20 2020, 2:09 PM

Harbormaster completed remote builds in B8133: Diff 24955.May 20 2020, 2:09 PM

Philipp Oeser (lichtwerk) requested review of this revision.May 20 2020, 2:09 PM

Looks good.

I have compared ffmpeg and blender output with lossless VP9 and they were close.

This revision is now accepted and ready to land.May 21 2020, 7:39 PM

Closed by commit rB98689f51c011: Fix T74443: No render in VP9 lossless mode (authored by Philipp Oeser (lichtwerk)). · Explain WhyMay 22 2020, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB98689f51c011: Fix T74443: No render in VP9 lossless mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

5 lines

Diff 25017

source/blender/blenkernel/intern/writeffmpeg.c

Loading...