Page MenuHome
Differential D7804

GPencil: Create new frame when Erase only if additive drawing is enabled
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on May 20 2020, 7:51 PM.

Details

Reviewers
Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)
Maniphest Tasks
T74608: Grease Pencil will not create new keyframe when using eraser tool
Commits
rB29afadcb15f7: GPencil: Create new frame when Erase only if additive drawing is enabled
Summary

This is related to task T74608 where the problem is described by @Braisque

The Eraser will create a new frame only if additive drawing is enabled:

This solves the problem with any of the two workflows.

This is a partial revert of the commit 0cbcc21a3b07

Diff Detail

Repository
rB Blender
Branch
temp-gpencil-erase-frame (branched from master)
Build Status
Buildable 8140
Build 8140: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.May 20 2020, 7:51 PM
Antonio Vazquez (antoniov) created this revision.
Harbormaster completed remote builds in B8140: Diff 24969.May 20 2020, 7:51 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 20 2020, 7:55 PM
Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).
Antonio Vazquez (antoniov) added a project: Grease Pencil.
Antonio Vazquez (antoniov) added a task: T74608: Grease Pencil will not create new keyframe when using eraser tool.
Antonio Vazquez (antoniov) added a subscriber: Unknown Object (User).
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 20 2020, 7:57 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 20 2020, 8:00 PM
Matias Mendiola (mendio) accepted this revision.May 20 2020, 8:30 PM
This revision is now accepted and ready to land.May 20 2020, 8:30 PM
Closed by commit rB29afadcb15f7: GPencil: Create new frame when Erase only if additive drawing is enabled (authored by Antonio Vazquez (antoniov)). · Explain WhyMay 20 2020, 8:34 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB29afadcb15f7: GPencil: Create new frame when Erase only if additive drawing is enabled.
Pratik Borhade (PratikPB2123) mentioned this in T102623: Grease Pencil: Erasing/Cutting does not auto-key layers.Nov 19 2022, 7:26 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
22 lines

Diff 24969

View Options

source/blender/editors/gpencil/gpencil_paint.c

Loading...