UI: Fix T76918: 3D Mouse Inconsistent / Inaccessible UI
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 20 2020, 10:06 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
William Reynish (billreynish)
Brecht Van Lommel (brecht)

Maniphest Tasks

T76918: 3D Mouse Inconsistent / Inaccessible UI

Commits

rBce0db0d32998: UI: Fix T76918: 3D Mouse Inconsistent / Inaccessible UI
rB7e4654e4ce2c: UI: Fix T76918: 3D Mouse Inconsistent / Inaccessible UI

Summary

This consolidates the UI code for NDOF input settings, making all settings accessible from the preferences.

This works around an issue where the Space Navigator's "Menu" button doesn't trigger the menu in Blender.
There's also no good reason not to make all preferences available in the preferences window.

I also took the opportunity to redo the UI layout which was quite a mess:

	Preferences	2D View	3D View
Before
After

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 20 2020, 10:06 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B8142: Diff 24972.May 20 2020, 10:06 PM

Hans Goudey (HooglyBoogly) edited reviewers, added: William Reynish (billreynish); removed: • William Reynish (billrey).May 20 2020, 10:07 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)May 20 2020, 10:10 PM

Hans Goudey (HooglyBoogly) added a task: T76918: 3D Mouse Inconsistent / Inaccessible UI.

Brecht Van Lommel (brecht) accepted this revision.May 20 2020, 10:13 PM

This revision is now accepted and ready to land.May 20 2020, 10:13 PM

Brecht Van Lommel (brecht) awarded a token.May 20 2020, 10:13 PM

LGTM. Indeed, it was quite strange that some items were not included in Preferences.

Generally fine, would keep the draw method in USERPREF_PT_ndof_settings instead of adding a new class as these files already have a lot of classes which can get a bit out of hand, and this layout is often accessed from the popup panel.

release/scripts/startup/bl_ui/space_userpref.py
1424	Don't think an extra class is needed just to share a function, it could be a static method in the `USERPREF_PT_ndof_settings` class.
1428	We normally use `draw_` for layout functions, prefer `show_3dview_settings`.