Fix T76776: Implement vertex_visibility_get for PBVH_GRIDS
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on May 21 2020, 12:10 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T76776: Face Set From Visible not working correctly with Multires

Commits

rB85098bdb8949: Fix T76776: Implement vertex_visibility_get for PBVH_GRIDS

Summary

This was missing from when Face Sets were enabled in Multires, so it was
always considering that all vertices in the grids are visible. This
should also fix other unreported bugs.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.May 21 2020, 12:10 AM

Harbormaster completed remote builds in B8144: Diff 24976.May 21 2020, 12:10 AM

Pablo Dobarro (pablodp606) requested review of this revision.May 21 2020, 12:10 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).May 21 2020, 5:07 PM

Sergey Sharybin (sergey) added inline comments.May 25 2020, 11:06 AM

source/blender/blenkernel/BKE_pbvh.h
232	`PBVH *pbvh` Although, it 's a mess here already, `bvh` and `pbvh` are used interchangeably. Should convolve to `pbvh`. Better to do as a separate change, before or after this one.
source/blender/editors/sculpt_paint/sculpt.c
269	Checking for `grid_index` seems weird to me. The very first grid (which will have index 0) will not be checked here?