Page MenuHome

Invert buttons for VertexWeightMix Vertex Groups
ClosedPublic

Authored by Likkez (Likkez) on May 21 2020, 9:38 PM.

Details

Summary


I've found it really frustrating that the invert buttons were missing. Previously, I had to manually copy a vertex group and invert it in Weight Paint.
That workflow has proven to be pretty destructive (if new verticies are created, they aren't included in the manually inverted vertex group and you had to go through all inverted groups you manually created and redo them for each modifier).
I hope this gets accepted because it will really speed up the workflow for that node.

Diff Detail

Event Timeline

Likkez (Likkez) requested review of this revision.May 21 2020, 9:38 PM
Likkez (Likkez) created this revision.

LGTM, besides naming of things (will fix while committing), thanks!

source/blender/makesdna/DNA_modifier_types.h
1507–1508

Those are not masking vgroups, but input data… so MOD_WVG_MIX_INVERT_INPUT_VGROUP_A or something like that.

source/blender/makesrna/intern/rna_modifier.c
5007

Naming again… something like invert_vertex_group_a at least.

source/blender/modifiers/intern/MOD_weightvgmix.c
227–228

no need for _mask here, those are input data, not masking vgroup…

This revision is now accepted and ready to land.May 29 2020, 6:07 PM