Page MenuHome

Fix T73726: Workbench Closest Interpolation Artifacts
ClosedPublic

Authored by Jeroen Bakker (jbakker) on May 22 2020, 9:03 AM.

Details

Summary

All textures in workbench are using linear interpolation. The fragment
shader modifies the uv coordinates to sample always in the center of a
texel. In rare conditions the GPU could sample an incorrect value due to
rounding errors making some rendering artifacts.

This patch skips the interpolation in the fragment shader to remove
these render artifacts.

Diff Detail

Repository
rB Blender

Event Timeline

Clément Foucault (fclem) added inline comments.
source/blender/draw/engines/workbench/shaders/workbench_image_lib.glsl
55

i feel this is wrong. i did not test but the Z is already non-normalized for array textures.

This revision is now accepted and ready to land.May 22 2020, 12:29 PM
Clément Foucault (fclem) requested changes to this revision.May 22 2020, 12:30 PM

oops accidentaly approved

This revision now requires changes to proceed.May 22 2020, 12:30 PM

Fixed texture array

Jeroen Bakker (jbakker) marked an inline comment as done.May 22 2020, 1:40 PM
source/blender/draw/engines/workbench/shaders/workbench_image_lib.glsl
55

You're right.

This revision is now accepted and ready to land.May 22 2020, 1:57 PM