Implementation of specular transparency property in GLSL render
ClosedPublic
Actions

Authored by Dontsov Valentin (valentin_b4w) on Sep 9 2014, 3:43 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Antonis Ryakiotakis (psy-fi)

Commits

rBS8c712eaa2971: GLSL: specular transparency support for Blender internal materials
rB8c712eaa2971: GLSL: specular transparency support for Blender internal materials

Summary

When object is transparent, modelers find it important to show specular shading with specular transparency. Current GLSL shading model doesn't support it yet. This diff fixes this issue.

Before:

After:

Best regards,
Valentin. Blend4Web Team.

Diff Detail

Event Timeline

Dontsov Valentin (valentin_b4w) updated this revision to Diff 2559.Sep 9 2014, 3:43 PM

Dontsov Valentin (valentin_b4w) retitled this revision from to Implementation of specular transparency property in GLSL render.

Dontsov Valentin (valentin_b4w) updated this object.

Dontsov Valentin (valentin_b4w) added reviewers: Brecht Van Lommel (brecht), Ton Roosendaal (ton).

Dontsov Valentin (valentin_b4w) set the repository for this revision to rB Blender.

Dontsov Valentin (valentin_b4w) added projects: Render Pipeline, GPU / Viewport.

Dontsov Valentin (valentin_b4w) updated this object.Sep 9 2014, 3:48 PM

Alexander Kovelenov (AlexKowel) added a subscriber: Alexander Kovelenov (AlexKowel).Sep 9 2014, 4:10 PM

Kévin Dietrich (kevindietrich) edited reviewers, added: Sergey Sharybin (sergey), Antonis Ryakiotakis (psy-fi); removed: Ton Roosendaal (ton).Sep 9 2014, 7:20 PM

Brecht Van Lommel (brecht) requested changes to this revision.Sep 10 2014, 1:26 AM

Brecht Van Lommel (brecht) edited edge metadata.

Brecht Van Lommel (brecht) added inline comments.

source/blender/gpu/intern/gpu_material.c

852–853

You can optimize this so that the alpha_spec_correction function call is only generated when needed, like e.g. this code.

if (GPU_link_changed(shi->spec) || ma->spec != 0.0f)
    GPU_link(mat, "shade_add", shr->combined, shr->spec, &shr->combined);

852–853

This code is not in the right place, now it will be executed for every lamp, but it should be only executed once afterwards, same as in shadeoutput.c.

    /* ambient color */
    if (world->ambr!=0.0f || world->ambg!=0.0f || world->ambb!=0.0f) {
        if (GPU_link_changed(shi->amb) || ma->amb != 0.0f)
            GPU_link(mat, "shade_maddf", shr->combined, GPU_uniform(&ma->amb),
                GPU_uniform(&world->ambr), &shr->combined);
    }
}

// >>> do it here <<<

if (ma->mode & MA_RAMP_COL) ramp_diffuse_result(shi, &shr->combined);
if (ma->mode & MA_RAMP_SPEC) ramp_spec_result(shi, &shr->spec);

This revision now requires changes to proceed.Sep 10 2014, 1:26 AM

Evgeny_Rodygin added a subscriber: Evgeny_Rodygin.Sep 10 2014, 8:08 AM

Moved part of code to the right place. Added optimizing condition.

Looks good to me.

I or someone else can commit this once master is open again for new features, in about 2-3 weeks from now according to the schedule:
http://wiki.blender.org/index.php/Dev:Doc/Projects

This revision is now accepted and ready to land.Sep 11 2014, 12:24 AM

Yuri Kovelenov (yurikovelenov) added a subscriber: Yuri Kovelenov (yurikovelenov).Oct 24 2014, 4:13 PM