Page MenuHome
Differential D7822

Fix T76897: Lamp Power Not Updating from Driver
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on May 22 2020, 6:19 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB41bb0548b0c1: Fix T76897: Lamp Power Not Updating from Driver
Summary

The issue was that lamps were not tagged with ID_RECALC_SHADING when they were updated from drivers. As a result, Cycles considered the lamp as unchanged. This is resolved by having a (seemingly non-functional) callback in a new LIGHT_UPDATE depsgraph node.

This patch unconditionally adds the LIGHT_UPDATE node + the relation from the lamp's PARAMETERS node.

Diff Detail

Repository
rB Blender
Branch
temp-lamp-cycles-update-fix-T76897
Build Status
Buildable 8169
Build 8169: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) created this revision.May 22 2020, 6:19 PM
Harbormaster completed remote builds in B8169: Diff 25019.May 22 2020, 6:19 PM
Sybren A. Stüvel (sybren) requested review of this revision.May 22 2020, 6:19 PM
Sybren A. Stüvel (sybren) added a project: BF Blender (2.83).May 22 2020, 6:19 PM
Brecht Van Lommel (brecht) accepted this revision.May 22 2020, 6:31 PM
This revision is now accepted and ready to land.May 22 2020, 6:31 PM
Closed by commit rB41bb0548b0c1: Fix T76897: Lamp Power Not Updating from Driver (authored by Sybren A. Stüvel (sybren)). · Explain WhyMay 25 2020, 10:43 AM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB41bb0548b0c1: Fix T76897: Lamp Power Not Updating from Driver.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
3 lines
intern/
7 lines
depsgraph/
intern/
builder/
7 lines
8 lines
node/
1 line
2 lines

Diff 25019

View Options

source/blender/blenkernel/BKE_light.h

Loading...
View Options

source/blender/blenkernel/intern/light.c

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Loading...
View Options

source/blender/depsgraph/intern/node/deg_node_operation.h

Loading...
View Options

source/blender/depsgraph/intern/node/deg_node_operation.cc

Loading...