Page MenuHome
Differential D7824

Add a check before triggering unnecessary rendered view redraws in Node Editor
AbandonedPublic
Actions

Authored by Nikhil Shringarpurey (Nikhil.Net) on May 22 2020, 8:46 PM.

Details

Reviewers
None
Summary

As per https://developer.blender.org/T76970:

Currently, any click in the node editor triggers a dependency graph update. This forces a redraw if the 3D view is set to Rendered View and the render engine is Cycles. For a complex scene, these forced redraws could be very annoying to live with.

This Diff does a check to see if a node is active and if the current spaceNode is flagged as "is_updating". If so, it still fires the update. But if not, the update is suppressed.

This eliminates the unneeded forced redraws but also keeps full functionality.

Diff Detail

Repository
rB Blender

Event Timeline

Nikhil Shringarpurey (Nikhil.Net) requested review of this revision.May 22 2020, 8:46 PM
Nikhil Shringarpurey (Nikhil.Net) created this revision.
Nikhil Shringarpurey (Nikhil.Net) mentioned this in T76970: Cycles viewport unneccessary update calls.
Daniel Ulrich (dulrich) awarded a token.May 24 2020, 12:47 PM
Brecht Van Lommel (brecht) abandoned this revision.May 25 2020, 7:50 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Thanks for the patch, but there is a more complete solution for this in D7830: Fix T76970: Unneccessary update calls viewport.

is_updating also wasn't the right variable to check, it's used for avoid infinite recursion rather than indicating if the nodetree was modified.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
7 lines

Diff 25023

View Options

source/blender/editors/space_node/node_select.c

Loading...