Differential D7834

Fix T77049: VSE Image cache is not refreshed when strip are muted/ unmuted in metastrip
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 25 2020, 12:40 PM.

Details

Reviewers

Richard Antalik (ISS)

Maniphest Tasks

T77049: VSE Image cache is not refreshed when strip are muted/unmuted in metastrip

Commits

rB2299f6b5a7e3: Fix T77049: VSE Image cache is not refreshed when strip are muted/

Diff Detail

Repository

rB Blender

Branch

T77049 (branched from master)

Build Status

Buildable 8193
Build 8193: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.May 25 2020, 12:40 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B8193: Diff 25064.May 25 2020, 12:41 PM

Philipp Oeser (lichtwerk) added projects: VFX & Video, Video Sequencer.May 25 2020, 12:43 PM

I wasn't sure if DEG_id_tag_update was needed for updating sound, but it seems this works OK.

This revision is now accepted and ready to land.May 25 2020, 1:04 PM

In D7834#189010, @Richard Antalik (ISS) wrote:

I wasn't sure if DEG_id_tag_update was needed for updating sound, but it seems this works OK.

rna_Sequence_invalidate_raw_update > BKE_sequence_invalidate_cache_raw > sequence_invalidate_cache does exactly that:
https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/sequencer.c$4206

Closed by commit rB2299f6b5a7e3: Fix T77049: VSE Image cache is not refreshed when strip are muted/ (authored by Philipp Oeser (lichtwerk)). · Explain WhyMay 26 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB2299f6b5a7e3: Fix T77049: VSE Image cache is not refreshed when strip are muted/.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_sequencer.c

9 lines

Diff 25064

View Options

source/blender/makesrna/intern/rna_sequencer.c

Fix T77049: VSE Image cache is not refreshed when strip are muted/ unmuted in metastripClosedPublicActions