Page MenuHome

Fix: previous/next navigation broken for the default directory.
Needs ReviewPublic

Authored by Nicholas Rishel (nicholas_rishel) on May 27 2020, 3:17 AM.

Details

Summary

Previously BKE_appdir_folder_default would return a path without
trailing slash. This funtion is only used with SpaceFile's params->dir,
where dir is normally a path with trailing slash. This change makes the
default path consistent with other uses of params->dir.

This fixes previous/next navigation where stepping "back" into the
default folder was recorded as a newly visited folder, where the next
folder list was reset and the previous folder list became [default
folder]->[default folder with trailing slash].

Edit: arc diff created a new revision instead of updating D5735.

Diff Detail

Repository
rB Blender
Branch
file_browser_undo (branched from master)
Build Status
Buildable 8234
Build 8234: arc lint + arc unit

Event Timeline

Nicholas Rishel (nicholas_rishel) created this revision.
Nicholas Rishel (nicholas_rishel) edited the summary of this revision. (Show Details)

I found that untangling the memory safety of BLI path utils while pushing/popping from directory history to be non-obvious without pessimistic string copying; as is this fix is likely the safest and most time effect way to solve the problem as it keeps the string manipulation close to the declaration.

This revision is now accepted and ready to land.Oct 6 2020, 12:45 PM

This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.

(in this case this patch can probably be committed as it is though)

This revision now requires review to proceed.Mar 26 2021, 5:56 PM