Fix T75096: Crash when using liquid simulation as dynamic paint brush
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 27 2020, 2:23 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Bastien Montagne (mont29)

Maniphest Tasks

T75096: Crash Baking Dynamic Paint using Liquid Simulation as Brush

Commits

rB735119dd0f91: Fix T75096: Crash when using liquid simulation as dynamic paint brush

Summary

This adds some bounds checking. It fixes the crash for me. I have no
idea of the real bug is earlier in the code... Maybe someone else
knows the code a bit better.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.May 27 2020, 2:23 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B8245: Diff 25159.May 27 2020, 2:23 PM

Jacques Lucke (JacquesLucke) added a task: T75096: Crash Baking Dynamic Paint using Liquid Simulation as Brush.May 27 2020, 2:24 PM

Not really my area, but there are reasonable amount of places where code compares tri_index to -1.

So one thing i would do in this patch is to compare to -1 rather than to be equal or greater than 0 (to match other checks in the code).
Whether or not all the usages of tri_index needs check I don't know since some of the checks might be already done in the parent scopes.