Sculpt: Cloth Filter
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on May 27 2020, 10:59 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB1d4bae856690: Sculpt: Cloth Filter

Summary

This tool is similar to the cloth brush, but it applies the cloth
simulation deformation to the whole mesh in an uniform way. The
simulation can be controlled using the mask to pin vertices and the face
sets to define force action areas.

It uses the same solver as the cloth brush which now no longer depends
on StrokeCache.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.May 27 2020, 10:59 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B8251: Diff 25174.May 27 2020, 10:59 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)May 27 2020, 11:00 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Andrey (andruxa696) awarded a token.May 27 2020, 11:07 PM

jorge (jorsh) awarded a token.May 27 2020, 11:19 PM

Brandon (Brandon777) awarded a token.May 27 2020, 11:48 PM

Christian Friedrich (rbx775) awarded a token.May 27 2020, 11:57 PM

Fran Marz (franMarz) awarded a token.May 27 2020, 11:59 PM

Rodger Davis (RodDavis) awarded a token.May 28 2020, 12:07 AM

Fix gravity filter
Fix incorrect face set when initializing the filter
Add pinch

Harbormaster completed remote builds in B8252: Diff 25175.May 28 2020, 12:07 AM

Diogo Valadares Reis dos Santos (DiogoX2) awarded a token.May 28 2020, 12:12 AM

Add sculpt gravity to the simulation (like the cloth brush)

This allows to run any cloth filter with gravity in any direction applied at the same time

Harbormaster completed remote builds in B8253: Diff 25176.May 28 2020, 12:17 AM

Luis Alfonso Prada Villamizar (Dardranight) awarded a token.May 28 2020, 2:30 AM

Vyacheslav (hitrpr) awarded a token.May 28 2020, 3:12 AM

Piotr Adamowicz (madminstrel) awarded a token.May 28 2020, 8:35 AM

Generally seems fine, but please consider splitting no-functional changes from functional ones.
For example, you could have made a refactor of explicitly passing cloth_sim as a separate change, which is a no-functional-change, can go in without review, and makes functional changes review more clear.
Such approach also makes it easy to distinguish functional from non-functional changes, which makes life much easier when non-functional-changes did case some side effects.