Fix T73056: Cache not invalidated in fade operator
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on May 30 2020, 3:22 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T73056: Various bugs with fade in/out with the VSE (Sequencer)

Commits

rB67a822e08684: Fix T73056: Cache not invalidated in fade operator

Summary

This operator is written in python it is inserting keyframes to create fade
effects.

Add Sequence.invalidate() python function to invalidate strip if it is
changed in python.

Perhaps I could implement cache invalidation to actual curve manipulation.
I guess it wouldn't be very hard to do but having means to invalidate form
python is useful as well.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 30 2020, 3:22 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B8297: Diff 25258.May 30 2020, 3:22 AM

Ideally the dependency graph would take care of this the way it does for physics caches, but we are quite far from having that for the sequencer. So this looks fine.

source/blender/makesrna/intern/rna_sequencer_api.c
507	This description should be extended, and perhaps the function name can be changed to `invalidate_cache`? Otherwise it's not clear at all this is related to the cache.
508	cache type -> Cache Type

This revision now requires changes to proceed.Jun 2 2020, 7:21 AM

Address inlines.

Harbormaster completed remote builds in B8345: Diff 25429.Jun 3 2020, 2:07 AM

Brecht Van Lommel (brecht) accepted this revision.Jun 3 2020, 7:28 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/makesrna/intern/rna_sequencer_api.c
507	Change to this (capitalization, US english spelling for dependent, and remove dot) : "Invalidate cached images for strip and all dependent strips"

This revision is now accepted and ready to land.Jun 3 2020, 7:28 PM

Closed by commit rB67a822e08684: Fix T73056: Cache not invalidated in fade operator (authored by Richard Antalik (ISS)). · Explain WhyJun 18 2020, 5:56 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB67a822e08684: Fix T73056: Cache not invalidated in fade operator.