Differential D7907

Fix T77264: Mantaflow: Liquid checkbox doesn't turn on while switching between fluid types
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jun 2 2020, 4:48 PM.

Details

Reviewers

Sebastián Barschkis (sebbas)

Maniphest Tasks

T77264: Mantaflow: Liquid checkbox doesn't turn on while switching between fluid types.

Commits

rBf9892bd6cf13: Fix T77264: Mantaflow: Liquid checkbox doesn't turn on while switching

Summary

When switching to gas, the fluids were not actually destroyed, leading to the situation that they were then destroyed when actually switching to liquid.

Diff Detail

Repository

rB Blender

Branch

T77264 (branched from master)

Build Status

Buildable 8328
Build 8328: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jun 2 2020, 4:48 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B8328: Diff 25396.Jun 2 2020, 4:48 PM

remove remainings from liquid sim when switching to gas instead

Harbormaster completed remote builds in B8352: Diff 25443.Jun 3 2020, 11:55 AM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Jun 3 2020, 11:56 AM

Philipp Oeser (lichtwerk) added a project: Nodes & Physics.

Looks good to me!

This revision is now accepted and ready to land.Jun 3 2020, 12:01 PM

Closed by commit rBf9892bd6cf13: Fix T77264: Mantaflow: Liquid checkbox doesn't turn on while switching (authored by Philipp Oeser (lichtwerk)). · Explain WhyJun 4 2020, 9:53 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBf9892bd6cf13: Fix T77264: Mantaflow: Liquid checkbox doesn't turn on while switching.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_fluid.c

2 lines

Diff 25396

View Options

source/blender/makesrna/intern/rna_fluid.c

Fix T77264: Mantaflow: Liquid checkbox doesn't turn on while switching between fluid typesClosedPublicActions