UI: Fix T77173: Report Background Colors for 2.83 Release
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jun 2 2020, 5:50 PM.

Details

Reviewers

Julian Eisel (Severin)
Dalai Felinto (dfelinto)

Maniphest Tasks

T77173: UI warnings contrast worsened from 2.82 to 2.83

Commits

rB7fc0053c27e5: UI: Fix T77173: Report Background Colors for 2.83 Release

Summary

This is a temporary solution for T77173 for the 2.83 release. D7203 provides
a more long term solution for future releases.

This adds theme colors for the three report backgrounds, setting them to the color
used in 2.82.

	2.82	2.83	Patch
Error
Warning
Info

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 2 2020, 5:50 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B8331: Diff 25402.Jun 2 2020, 5:50 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 2 2020, 5:53 PM

Hans Goudey (HooglyBoogly) added a task: T77173: UI warnings contrast worsened from 2.82 to 2.83.Jun 2 2020, 6:01 PM

Did you check the bundled themes, does the new color work for these? I realize they were only added in 2.83, so there is no old color we can use.
Besides that this seems fine, although I have to test it to double check still.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 2 2020, 6:19 PM

Some of the white themes aren't great. Do you want me to include updates to those here?

I'm not actually sure I have commit access to the addons repo though.

Blender light:

diff --git a/release/scripts/presets/interface_theme/blender_light.xml b/release/scripts/presets/interface_theme/blender_light.xml
index f4ec8233df3..dbc7dd782da 100644
--- a/release/scripts/presets/interface_theme/blender_light.xml
+++ b/release/scripts/presets/interface_theme/blender_light.xml
@@ -1052,6 +1052,9 @@
         info_property_text="#ffffff"
         info_operator="#3ace87ff"
         info_operator_text="#ffffff"
+        info_report_error="#990000"
+        info_report_warning="#b36a00"
+        info_report_info="#6080ff"
         >
         <space>
           <ThemeSpaceGeneric

Other theme changes are here: P1442