Details

Reviewers

Maniphest Tasks

T77156: GPencil: Problem with assigning layers to view layers

Commits

rB09db0f2a3467: Fix T77156: GPencil view layer filter by layer not working
rB4184371fb04e: Fix T77156: GPencil view layer filter by layer not working

Summary

This feature was removed by error during the refactor.

The filter is used to help in composition to get different layers by viewlayer. This is applied only in final render and never in viewport.

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Jun 2 2020, 6:02 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B8332: Diff 25403.Jun 2 2020, 6:02 PM

Antonio Vazquez (antoniov) added a task: T77156: GPencil: Problem with assigning layers to view layers.Jun 2 2020, 6:02 PM

Antonio Vazquez (antoniov) added a reviewer: Clément Foucault (fclem).

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Antonio Vazquez (antoniov) added subscribers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).

Clément Foucault (fclem) added inline comments.Jun 3 2020, 9:28 AM

source/blender/blenkernel/intern/gpencil.c
1886	comment is hard to understand.
source/blender/draw/intern/draw_cache_impl_gpencil.c
369	not sure you want to hide inside the batch creation.

GPencil: Use view_layer instead depsgraph

Harbormaster completed remote builds in B8350: Diff 25438.Jun 3 2020, 9:38 AM

GPencil: Move view_layer logic to cache

Harbormaster completed remote builds in B8351: Diff 25439.Jun 3 2020, 9:50 AM

GPencil: Simplify code

Harbormaster completed remote builds in B8353: Diff 25449.Jun 3 2020, 12:49 PM

Clément Foucault (fclem) accepted this revision.Jun 3 2020, 12:53 PM

This revision is now accepted and ready to land.Jun 3 2020, 12:53 PM

Closed by commit rB4184371fb04e: Fix T77156: GPencil view layer filter by layer not working (authored by Antonio Vazquez (antoniov)). · Explain WhyJun 3 2020, 3:59 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB4184371fb04e: Fix T77156: GPencil view layer filter by layer not working.

Jeroen Bakker (jbakker) added a commit: rB09db0f2a3467: Fix T77156: GPencil view layer filter by layer not working.Jun 11 2020, 8:39 AM

Proposed fix T77156: GPencil Viewlayer filter is not working
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25456

source/blender/blenkernel/BKE_gpencil.h

source/blender/blenkernel/intern/gpencil.c

source/blender/draw/engines/gpencil/gpencil_engine.h

source/blender/draw/engines/gpencil/gpencil_engine.c

source/blender/draw/engines/overlay/overlay_gpencil.c

source/blender/draw/engines/overlay/overlay_outline.c

source/blender/draw/intern/draw_cache_impl_gpencil.c

Proposed fix T77156: GPencil Viewlayer filter is not workingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25456

source/blender/blenkernel/BKE_gpencil.h

source/blender/blenkernel/intern/gpencil.c

source/blender/draw/engines/gpencil/gpencil_engine.h

source/blender/draw/engines/gpencil/gpencil_engine.c

source/blender/draw/engines/overlay/overlay_gpencil.c

source/blender/draw/engines/overlay/overlay_outline.c

source/blender/draw/intern/draw_cache_impl_gpencil.c

Proposed fix T77156: GPencil Viewlayer filter is not working
ClosedPublic
Actions

Revision Contents
Changeset List