Details
- Reviewers
Brecht Van Lommel (brecht) - Group Reviewers
User Interface - Maniphest Tasks
- T77226: Eyedropper does not work from another blender instance
- Commits
- rBb94ab93dfb82: Eyedropper: Support get samples from other windows
Diff Detail
- Repository
- rB Blender
- Branch
- fix_T77226 (branched from master)
- Build Status
Buildable 8360 Build 8360: arc lint + arc unit
Event Timeline
Nice to see this finally tackled.
| source/blender/editors/interface/interface_eyedropper_color.c | ||
|---|---|---|
| 197–206 | Can this logic be moved earlier, so that it will also use specific code for the image/node/clip editor in other windows? | |
| source/blender/windowmanager/WM_api.h | ||
| 109–112 | Maybe these two API functions could be changed into one WM_window_find_under_cursor()? | |
| source/blender/windowmanager/intern/wm_window.c | ||
| 2012–2022 | Does this correctly handle overlapping windows? Seems like it would need to check the order somehow? The window might also be minimized, probably a test for that is needed? I guess the existing code this was copied from already had the problem, if there is any. | |
| 2041 | Is adding glFinish() really needed? | |
- Unify WM funcition and anticipate the logic to get the screen and the area under the cursor
| source/blender/windowmanager/intern/wm_window.c | ||
|---|---|---|
| 2041 | Probably not, but I copied this from the function below WM_window_pixels_read. | |
| source/blender/windowmanager/intern/wm_window.c | ||
|---|---|---|
| 2012–2022 | This is indeed a problem. | |
- Ignore minimized windows
- Add win_ignore variable to avoid breakage in the event system
| source/blender/windowmanager/intern/wm_window.c | ||
|---|---|---|
| 2012–2022 | There could be an arbitrary number of windows stacked. I think ideally we'd add some GHOST API function to get the order number of a window. But this can be left as a future improvement. Please leave a comment in the code about that. | |
- Remove glFinish (the original code does not use this resourse and we can re-implement if there are problems)
- Comment limitation in getting the order of windows
I can't seem to get this to work on Ubuntu 20.04, with a dual monitor setup and two Main windows of the same blender instance.
Also, is this intended to work with all the dropper tool or just for the colour picker? I asked this related question on stackexchange almost two years ago.
Oops. Yes, please, this is recommended.
Although I won't be able to fix it, since I can't reproduce the problem.
But I have some suspicions of what may be causing this.
Thanks.