Differential D7951

Fix T77548: Crash when using Interactive Mesh Tool with Normal Orientation and zero objects in scene.
ClosedPublic
Actions

Authored by Deep Majumder (dmcoder) on Jun 7 2020, 11:56 AM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T77548: Crash when using Interactive Mesh Tool with Normal Orientation and zero objects in scene.

Commits

rBc323f3e90a4a: Fix T77548: Crash when using Add Object Tool with Normal Orientation and zero…

Summary

The crash is caused by the fact that a NULL Object pointer is passed to calculate the transform orientation, which has been set to normal.
A check has been include to detect the same

Diff Detail

Repository: rB Blender

Event Timeline

Deep Majumder (dmcoder) requested review of this revision.Jun 7 2020, 11:56 AM

Deep Majumder (dmcoder) created this revision.

Harbormaster completed remote builds in B8418: Diff 25601.Jun 7 2020, 11:56 AM

Deep Majumder (dmcoder) edited the summary of this revision. (Show Details)Jun 7 2020, 12:01 PM

Deep Majumder (dmcoder) added reviewers: Campbell Barton (campbellbarton), Alaska (Alaska).

Deep Majumder (dmcoder) added projects: BF Blender (2.83), Modeling.

Alaska (Alaska) retitled this revision from Fixes T77548 to Fix T77548: Crash when using Interactive Mesh Tool with Normal Orientation and zero objects in scene..Jun 8 2020, 6:22 AM

Testing this patch out, I can confirm it fixes the issue.

Removing myself as a reviewer because I'm not a Blender developer and have very little experience in programming.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 8:46 PM

Closed by commit rBc323f3e90a4a: Fix T77548: Crash when using Add Object Tool with Normal Orientation and zero… (authored by Deep Majumder (dmcoder), committed by Germano Cavalcante (mano-wii)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rBc323f3e90a4a: Fix T77548: Crash when using Add Object Tool with Normal Orientation and zero….

Thanks for the patch.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_orientations.c

4 lines

Diff 27456

View Options

source/blender/editors/transform/transform_orientations.c

Fix T77548: Crash when using Interactive Mesh Tool with Normal Orientation and zero objects in scene.ClosedPublicActions