Fix T77267: Render EEVEE AO pass when AO disabled.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 8 2020, 2:55 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T77267: EEVEE: Render AO pass even when AO setting is disabled in Scene

Commits

rB68651534c263: Fix T77267: Render EEVEE AO pass when AO disabled.

Summary

In EEVEE the AO renderpass influenced other render passes. Until not the
pass wasn't selectable when AO was disabled in the scene to remove these
render artifacts.

This patch allows rendering EEVEE AO pass without enabling it in the
scene. It does this by binding a fallback texture that is used by the
surface shaders.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D7956 (branched from master)

Build Status

Buildable 9556
Build 9556: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 8 2020, 2:55 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B8430: Diff 25634.Jun 8 2020, 2:56 PM

Appart from the naming this looks good to me.

source/blender/draw/engines/eevee/eevee_occlusion.c
122	I prefer that `gtao_horizons` remain the one for the surface and that `gtao_horizons_renderpass` is used for the other. This is a bit more clear which is which.