Page MenuHome
Differential D7960

Remove Threaded Sculpt option
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Jun 8 2020, 10:06 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T77638: Remove the Threaded Sculpt option from menus
Commits
rB5d31ef082057: Remove Threaded Sculpt option
Summary

Threaded Sculpt is now always enabled by default. If it causes
performance problems compared single threaded sculpt it should be
considered a bug.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jun 8 2020, 10:06 PM
Pablo Dobarro (pablodp606) created this revision.
Harbormaster completed remote builds in B8443: Diff 25652.Jun 8 2020, 10:06 PM
Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Jun 8 2020, 10:06 PM
Pablo Dobarro (pablodp606) added a task: T77638: Remove the Threaded Sculpt option from menus.
Sergey Sharybin (sergey) requested changes to this revision.Jun 9 2020, 9:44 AM

use_threading argument of BKE_pbvh_parallel_range_settings is always truth, remove it.

source/blender/editors/sculpt_paint/paint_vertex.c
2174

You can not use flag which is marked as UNUSED.

This revision now requires changes to proceed.Jun 9 2020, 9:44 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.Jun 9 2020, 6:24 PM

@Sergey Sharybin (sergey) It is false in some parts of dyntopo and in the cloth brush

Pablo Dobarro (pablodp606) updated this revision to Diff 25696.Jun 9 2020, 6:25 PM
  • Review update
Harbormaster completed remote builds in B8471: Diff 25696.Jun 9 2020, 6:25 PM
Sergey Sharybin (sergey) accepted this revision.Jun 10 2020, 9:36 AM

It is false in some parts of dyntopo and in the cloth brush

Allright then.

This revision is now accepted and ready to land.Jun 10 2020, 9:36 AM
Closed by commit rB5d31ef082057: Remove Threaded Sculpt option (authored by Pablo Dobarro (pablodp606)). · Explain WhyJun 29 2020, 6:20 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB5d31ef082057: Remove Threaded Sculpt option.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1 line
source/
blender/
editors/
sculpt_paint/
6 lines
2 lines
63 lines
7 lines
2 lines
3 lines
6 lines
6 lines
6 lines
4 lines
8 lines
6 lines
4 lines
3 lines
2 lines
makesdna/
2 lines
makesrna/
intern/
6 lines

Diff 26374

View Options

release/scripts/startup/bl_ui/space_view3d_toolbar.py

Loading...
View Options

source/blender/editors/sculpt_paint/paint_mask.c

Loading...
View Options

source/blender/editors/sculpt_paint/paint_vertex.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_cloth.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_face_set.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_color.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_mask.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_mesh.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_mask_expand.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_multiplane_scrape.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_paint_color.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_pose.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_smooth.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_transform.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_undo.c

Loading...
View Options

source/blender/makesdna/DNA_scene_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_sculpt_paint.c

Loading...