Details

Reviewers

Julian Eisel (Severin)
William Reynish (billreynish)
Matias Mendiola (mendio)

Commits

rBec963d9d7d17: UI: Grease Pencil Modifier Drag and Drop, Layout Changes

Summary

This patch implements the list panel system D7490 for grease pencil modifiers. It also moves their drawing to a callback in GpencilModifierTypeInfo in line with the extensible architecture refactoring goal T75724.

I also added the "set_error" function for grease pencil modifiers, which hadn't been added from mesh modifiers yet.

The implementation is exactly the same as for the modifier patch.

Old	New

Diff Detail

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 10 2020, 12:20 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B8479: Diff 25720.Jun 10 2020, 12:20 AM

There are actually a few changes from the modifier patch I still have to port over

Fix error in patch creation
Add menu for consistency with modidifers

Any feedback about the menu can be applied to both grease pencil modifiers and mesh
modifiers together, but for now we can keep them consistent.

Harbormaster completed remote builds in B8481: Diff 25722.Jun 10 2020, 12:36 AM

Hans Goudey (HooglyBoogly) added a parent revision: D7499: UI: Drag and Drop Constraints, Layout Updates.Jun 10 2020, 12:37 AM

For some reason arc included D7499

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 12:43 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 12:47 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 1:00 AM

Use pinned object

William Reynish (billreynish) accepted this revision.Jun 10 2020, 7:02 AM

Hans Goudey (HooglyBoogly) added a child revision: D7985: UI: ShaderFx Drag and Drop, Layout Updates.Jun 10 2020, 6:58 PM

Hans Goudey (HooglyBoogly) mentioned this in D7985: UI: ShaderFx Drag and Drop, Layout Updates.

jorge (jorsh) awarded a token.Jun 10 2020, 11:56 PM

Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Jun 11 2020, 4:50 PM

Merge master
Changes from constraints patch

This revision is now accepted and ready to land.Jun 15 2020, 4:31 PM

Harbormaster completed remote builds in B8547: Diff 25922.Jun 15 2020, 4:31 PM

Expand array relative offset subpanel by default
Fix build error

Harbormaster completed remote builds in B8548: Diff 25923.Jun 15 2020, 4:43 PM

I have tested and it looks good to me.

All seems Ok, only the Build modifier is outdated, there is a new feature added: https://developer.blender.org/rBa1593fa05baf

This revision now requires changes to proceed.Jun 15 2020, 6:00 PM

In D7978#194716, @Matias Mendiola (mendio) wrote:

All seems Ok, only the Build modifier is outdated, there is a new feature added: https://developer.blender.org/rBa1593fa05baf

Oops! Good catch, I'll include that now.

In D7978#194716, @Matias Mendiola (mendio) wrote:

All seems Ok, only the Build modifier is outdated, there is a new feature added: https://developer.blender.org/rBa1593fa05baf

Actually I did add that, it's just labeled "Use Factor," which I thought was a better description for the property, since the entire Build modifier "restricts visible points" already. "Factor" at least implies that it's a more hardcoded value

Matias Mendiola (mendio) accepted this revision.Jun 15 2020, 8:14 PM

This revision is now accepted and ready to land.Jun 15 2020, 8:14 PM

Improvements to panel header

Harbormaster completed remote builds in B8560: Diff 25942.Jun 15 2020, 8:50 PM

Didn't find any obvious issue on a quick glance over the changes.
Again, didn't review the layout changes in detail and I can't speak for the design side of things.

Besides the two mentioned point, looks fine. (Also the constraint changes are in here too, I assume they are not part of the proposed changes :) )

source/blender/blenkernel/intern/gpencil_modifier.c
58	Should be "bke.gpencil_modifier" I guess.
source/blender/editors/object/object_gpencil_modifier.c
671	Would use the same description as in the constraint patch.

Closed by commit rBec963d9d7d17: UI: Grease Pencil Modifier Drag and Drop, Layout Changes (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJun 19 2020, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) marked 2 inline comments as done.

Hans Goudey (HooglyBoogly) added a commit: rBec963d9d7d17: UI: Grease Pencil Modifier Drag and Drop, Layout Changes.

UI: Grease Pencil Modifier Drag and Drop, Layout ChangesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25724

release/scripts/startup/bl_ui/properties_data_modifier.py

source/blender/blenkernel/BKE_gpencil_modifier.h

source/blender/blenkernel/intern/gpencil_modifier.c

source/blender/blenloader/intern/versioning_290.c

source/blender/editors/include/ED_object.h

source/blender/editors/include/UI_interface.h

source/blender/editors/interface/interface_templates.c

source/blender/editors/object/object_gpencil_modifier.c

source/blender/editors/object/object_intern.h

source/blender/editors/object/object_ops.c

source/blender/editors/space_buttons/space_buttons.c

source/blender/gpencil_modifiers/CMakeLists.txt

source/blender/gpencil_modifiers/intern/MOD_gpencil_ui_common.h

source/blender/gpencil_modifiers/intern/MOD_gpencil_ui_common.c

source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c

source/blender/gpencil_modifiers/intern/MOD_gpencilarray.c

source/blender/gpencil_modifiers/intern/MOD_gpencilbuild.c

source/blender/gpencil_modifiers/intern/MOD_gpencilcolor.c

source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c

source/blender/gpencil_modifiers/intern/MOD_gpencillattice.c

source/blender/gpencil_modifiers/intern/MOD_gpencilmirror.c

source/blender/gpencil_modifiers/intern/MOD_gpencilmultiply.c

source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c

source/blender/gpencil_modifiers/intern/MOD_gpenciloffset.c

source/blender/gpencil_modifiers/intern/MOD_gpencilopacity.c

source/blender/gpencil_modifiers/intern/MOD_gpencilsimplify.c

source/blender/gpencil_modifiers/intern/MOD_gpencilsmooth.c

source/blender/gpencil_modifiers/intern/MOD_gpencilsubdiv.c

source/blender/gpencil_modifiers/intern/MOD_gpenciltexture.c

source/blender/gpencil_modifiers/intern/MOD_gpencilthick.c

source/blender/gpencil_modifiers/intern/MOD_gpenciltime.c

source/blender/gpencil_modifiers/intern/MOD_gpenciltint.c

source/blender/makesdna/DNA_gpencil_modifier_types.h

source/blender/makesrna/intern/rna_gpencil_modifier.c

source/blender/makesrna/intern/rna_ui_api.c

UI: Grease Pencil Modifier Drag and Drop, Layout Changes
ClosedPublic
Actions

Revision Contents
Changeset List