Page MenuHome
Differential D7978

UI: Grease Pencil Modifier Drag and Drop, Layout Changes
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jun 10 2020, 12:20 AM.

Details

Reviewers
Julian Eisel (Severin)
William Reynish (billreynish)
Matias Mendiola (mendio)
Commits
rBec963d9d7d17: UI: Grease Pencil Modifier Drag and Drop, Layout Changes
Summary

This patch implements the list panel system D7490 for grease pencil modifiers. It also moves their drawing to a callback in GpencilModifierTypeInfo in line with the extensible architecture refactoring goal T75724.

I also added the "set_error" function for grease pencil modifiers, which hadn't been added from mesh modifiers yet.

The implementation is exactly the same as for the modifier patch.

OldNew

Diff Detail

Repository
rB Blender
Branch
gpencil-modifier-panels (branched from master)
Build Status
Buildable 8548
Build 8548: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 10 2020, 12:20 AM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B8479: Diff 25720.Jun 10 2020, 12:20 AM
Hans Goudey (HooglyBoogly) planned changes to this revision.Jun 10 2020, 12:26 AM

There are actually a few changes from the modifier patch I still have to port over

Hans Goudey (HooglyBoogly) updated this revision to Diff 25722.Jun 10 2020, 12:36 AM
  • Fix error in patch creation
  • Add menu for consistency with modidifers

Any feedback about the menu can be applied to both grease pencil modifiers and mesh
modifiers together, but for now we can keep them consistent.

Harbormaster completed remote builds in B8481: Diff 25722.Jun 10 2020, 12:36 AM
Hans Goudey (HooglyBoogly) added a parent revision: D7499: UI: Drag and Drop Constraints, Layout Updates.Jun 10 2020, 12:37 AM
Hans Goudey (HooglyBoogly) updated this revision to Diff 25724.Jun 10 2020, 12:39 AM

For some reason arc included D7499

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 12:43 AM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 12:47 AM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 1:00 AM
Hans Goudey (HooglyBoogly) planned changes to this revision.Jun 10 2020, 1:05 AM

Use pinned object

William Reynish (billreynish) accepted this revision.Jun 10 2020, 7:02 AM
Hans Goudey (HooglyBoogly) added a child revision: D7985: UI: ShaderFx Drag and Drop, Layout Updates.Jun 10 2020, 6:58 PM
Hans Goudey (HooglyBoogly) mentioned this in D7985: UI: ShaderFx Drag and Drop, Layout Updates.
jorge (jorsh) awarded a token.Jun 10 2020, 11:56 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Jun 11 2020, 4:50 PM
Hans Goudey (HooglyBoogly) updated this revision to Diff 25922.Jun 15 2020, 4:31 PM
  • Merge master
  • Changes from constraints patch
This revision is now accepted and ready to land.Jun 15 2020, 4:31 PM
Harbormaster completed remote builds in B8547: Diff 25922.Jun 15 2020, 4:31 PM
Hans Goudey (HooglyBoogly) updated this revision to Diff 25923.Jun 15 2020, 4:43 PM
  • Expand array relative offset subpanel by default
  • Fix build error
Harbormaster completed remote builds in B8548: Diff 25923.Jun 15 2020, 4:43 PM
Antonio Vazquez (antoniov) added a comment.Jun 15 2020, 5:45 PM

I have tested and it looks good to me.

Matias Mendiola (mendio) requested changes to this revision.Jun 15 2020, 6:00 PM

All seems Ok, only the Build modifier is outdated, there is a new feature added: https://developer.blender.org/rBa1593fa05baf

This revision now requires changes to proceed.Jun 15 2020, 6:00 PM
Hans Goudey (HooglyBoogly) added a comment.Jun 15 2020, 6:37 PM
In D7978#194716, @Matias Mendiola (mendio) wrote:

All seems Ok, only the Build modifier is outdated, there is a new feature added: https://developer.blender.org/rBa1593fa05baf

Oops! Good catch, I'll include that now.

Hans Goudey (HooglyBoogly) added a comment.Jun 15 2020, 8:02 PM
In D7978#194716, @Matias Mendiola (mendio) wrote:

All seems Ok, only the Build modifier is outdated, there is a new feature added: https://developer.blender.org/rBa1593fa05baf

Actually I did add that, it's just labeled "Use Factor," which I thought was a better description for the property, since the entire Build modifier "restricts visible points" already. "Factor" at least implies that it's a more hardcoded value

Matias Mendiola (mendio) accepted this revision.Jun 15 2020, 8:14 PM
This revision is now accepted and ready to land.Jun 15 2020, 8:14 PM
Hans Goudey (HooglyBoogly) updated this revision to Diff 25942.EditedJun 15 2020, 8:50 PM
  • Improvements to panel header


Harbormaster completed remote builds in B8560: Diff 25942.Jun 15 2020, 8:50 PM
Julian Eisel (Severin) accepted this revision.Jun 18 2020, 6:43 PM

Didn't find any obvious issue on a quick glance over the changes.
Again, didn't review the layout changes in detail and I can't speak for the design side of things.

Besides the two mentioned point, looks fine. (Also the constraint changes are in here too, I assume they are not part of the proposed changes :) )

source/blender/blenkernel/intern/gpencil_modifier.c
58

Should be "bke.gpencil_modifier" I guess.

source/blender/editors/object/object_gpencil_modifier.c
671

Would use the same description as in the constraint patch.

Closed by commit rBec963d9d7d17: UI: Grease Pencil Modifier Drag and Drop, Layout Changes (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJun 19 2020, 8:42 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) marked 2 inline comments as done.
Hans Goudey (HooglyBoogly) added a commit: rBec963d9d7d17: UI: Grease Pencil Modifier Drag and Drop, Layout Changes.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1231 lines
484 lines
source/
blender/
blenkernel/
5 lines
10 lines
intern/
21 lines
42 lines
blenloader/
intern/
30 lines
draw/
engines/
overlay/
2 lines
editors/
include/
4 lines
5 lines
interface/
381 lines
object/
70 lines
86 lines
2 lines
2 lines
space_buttons/
9 lines
gpencil_modifiers/
5 lines
intern/
66 lines
413 lines
45 lines
152 lines
92 lines
48 lines
87 lines
60 lines
46 lines
76 lines
78 lines
41 lines
86 lines
54 lines
53 lines
40 lines
62 lines
52 lines
97 lines
62 lines
makesdna/
7 lines
4 lines
makesrna/
intern/
10 lines
13 lines
19 lines

Diff 25923

View Options

release/scripts/startup/bl_ui/properties_constraint.py

Loading...
View Options

release/scripts/startup/bl_ui/properties_data_modifier.py

Loading...
View Options

source/blender/blenkernel/BKE_constraint.h

Loading...
View Options

source/blender/blenkernel/BKE_gpencil_modifier.h

Loading...
View Options

source/blender/blenkernel/intern/constraint.c

Loading...
View Options

source/blender/blenkernel/intern/gpencil_modifier.c

Loading...
View Options

source/blender/blenloader/intern/versioning_290.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_extra.c

Loading...
View Options

source/blender/editors/include/ED_object.h

Loading...
View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/interface/interface_templates.c

Loading...
View Options

source/blender/editors/object/object_constraint.c

Loading...
View Options

source/blender/editors/object/object_gpencil_modifier.c

Loading...
View Options

source/blender/editors/object/object_intern.h

Loading...
View Options

source/blender/editors/object/object_ops.c

Loading...
View Options

source/blender/editors/space_buttons/space_buttons.c

Loading...
View Options

source/blender/gpencil_modifiers/CMakeLists.txt

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencil_ui_common.h

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencil_ui_common.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilarray.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilbuild.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilcolor.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillattice.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilmirror.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilmultiply.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciloffset.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilopacity.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsimplify.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsmooth.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsubdiv.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciltexture.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilthick.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciltime.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciltint.c

Loading...
View Options

source/blender/makesdna/DNA_constraint_types.h

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_constraint.c

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Loading...
View Options

source/blender/makesrna/intern/rna_ui_api.c

Loading...