Page MenuHome
Differential D7985

UI: ShaderFx Drag and Drop, Layout Updates
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jun 10 2020, 6:56 PM.

Details

Reviewers
Julian Eisel (Severin)
William Reynish (billreynish)
Matias Mendiola (mendio)
Commits
rBbb4cef71eeaf: UI: ShaderFx Drag and Drop, Layout Updates
Summary

This patch implements the list panel system D7490 for grease pencil shader effects. It also moves their drawing to a callback in ShaderFxTypeInfo in line with the extensible architecture refactoring goal T75724.

The implementation is exactly the same as for the modifier patch.

@Matias Mendiola (mendio) and I worked out the layout updates together.

OldNew

This patch is a diff from D7978, which is a diff from D7499, so it might not be the easiest patch to apply. Aside from the layouts, everything is the same changes as the other patches though.

Diff Detail

Repository
rB Blender
Branch
modifier-panels-ui
Build Status
Buildable 8552
Build 8552: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 10 2020, 6:56 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) added parent revisions: D7978: UI: Grease Pencil Modifier Drag and Drop, Layout Changes, D7499: UI: Drag and Drop Constraints, Layout Updates.
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Jun 10 2020, 7:00 PM
William Reynish (billreynish) accepted this revision.Jun 10 2020, 11:20 PM
This revision is now accepted and ready to land.Jun 10 2020, 11:20 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Jun 11 2020, 4:51 PM
Hans Goudey (HooglyBoogly) updated this revision to Diff 25931.Jun 15 2020, 5:31 PM
  • Merge branch 'master' into modifier-panels-ui
  • Remove unintentional changes, use pinned object
Harbormaster completed remote builds in B8552: Diff 25931.Jun 15 2020, 5:31 PM
Hans Goudey (HooglyBoogly) updated this revision to Diff 25933.Jun 15 2020, 5:34 PM

Manual diff

Matias Mendiola (mendio) accepted this revision.Jun 15 2020, 6:12 PM
Julian Eisel (Severin) accepted this revision.Jun 19 2020, 8:19 PM

This seems to be the same logic as added for constraints and modifiers already, so I'll assume this is fine. Didn't find anything on a quick scan either.

Closed by commit rBbb4cef71eeaf: UI: ShaderFx Drag and Drop, Layout Updates (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJun 19 2020, 9:07 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBbb4cef71eeaf: UI: ShaderFx Drag and Drop, Layout Updates.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1231 lines
484 lines
118 lines
source/
blender/
blenkernel/
5 lines
10 lines
7 lines
intern/
21 lines
42 lines
20 lines
blenloader/
intern/
30 lines
draw/
engines/
overlay/
2 lines
editors/
include/
8 lines
8 lines
interface/
511 lines
object/
70 lines
86 lines
3 lines
3 lines
85 lines
space_buttons/
19 lines
gpencil_modifiers/
5 lines
intern/
66 lines
413 lines
45 lines
149 lines
92 lines
48 lines
87 lines
60 lines
46 lines
76 lines
78 lines
41 lines
86 lines
54 lines
53 lines
40 lines
62 lines
52 lines
97 lines
62 lines
makesdna/
7 lines
4 lines
5 lines
makesrna/
intern/
10 lines
13 lines
6 lines
25 lines
shader_fx/
5 lines
intern/
40 lines
47 lines
36 lines
48 lines
10 lines
38 lines
49 lines
94 lines
32 lines
35 lines
56 lines
272 lines

Diff 25931

View Options

release/scripts/startup/bl_ui/properties_constraint.py

Loading...
View Options

release/scripts/startup/bl_ui/properties_data_modifier.py

Loading...
View Options

release/scripts/startup/bl_ui/properties_data_shaderfx.py

Loading...
View Options

source/blender/blenkernel/BKE_constraint.h

Loading...
View Options

source/blender/blenkernel/BKE_gpencil_modifier.h

Loading...
View Options

source/blender/blenkernel/BKE_shader_fx.h

Loading...
View Options

source/blender/blenkernel/intern/constraint.c

Loading...
View Options

source/blender/blenkernel/intern/gpencil_modifier.c

Loading...
View Options

source/blender/blenkernel/intern/shader_fx.c

Loading...
View Options

source/blender/blenloader/intern/versioning_290.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_extra.c

Loading...
View Options

source/blender/editors/include/ED_object.h

Loading...
View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/interface/interface_templates.c

Loading...
View Options

source/blender/editors/object/object_constraint.c

Loading...
View Options

source/blender/editors/object/object_gpencil_modifier.c

Loading...
View Options

source/blender/editors/object/object_intern.h

Loading...
View Options

source/blender/editors/object/object_ops.c

Loading...
View Options

source/blender/editors/object/object_shader_fx.c

Loading...
View Options

source/blender/editors/space_buttons/space_buttons.c

Loading...
View Options

source/blender/gpencil_modifiers/CMakeLists.txt

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencil_ui_common.h

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencil_ui_common.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilarmature.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilarray.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilbuild.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilcolor.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillattice.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilmirror.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilmultiply.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciloffset.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilopacity.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsimplify.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsmooth.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsubdiv.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciltexture.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilthick.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciltime.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpenciltint.c

Loading...
View Options

source/blender/makesdna/DNA_constraint_types.h

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_types.h

Loading...
View Options

source/blender/makesdna/DNA_shader_fx_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_constraint.c

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Loading...
View Options

source/blender/makesrna/intern/rna_shader_fx.c

Loading...
View Options

source/blender/makesrna/intern/rna_ui_api.c

Loading...
View Options

source/blender/shader_fx/CMakeLists.txt

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_blur.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_colorize.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_flip.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_glow.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_light.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_pixel.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_rim.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_shadow.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_swirl.c

Loading...
View Options

source/blender/shader_fx/intern/FX_shader_wave.c

Loading...
View Options

source/blender/shader_fx/intern/FX_ui_common.h

Loading...
View Options

source/blender/shader_fx/intern/FX_ui_common.c

Loading...