Differential D8011

Cycles: remove UV and INSTANCING as kernel options
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 12 2020, 10:48 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Group Reviewers

Cycles

Maniphest Tasks

T73778: Cycles: Embree improvements

Commits

rC7ccace12313d: Remove __uv__ and __instancing__ as kernel options
rB1de0e13af619: Cycles: remove __UV__ and __INSTANCING__ as kernel options

Summary

The kernel did not work correctly when these were disabled anyway. The
optimized BVH traversal for the no instances case was also only used on
the CPU, so no longer makes sense to keep.

Ref T73778

Depends on D8010

Diff Detail

Repository

rB Blender

Build Status

Buildable 8528
Build 8528: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jun 12 2020, 10:48 PM

Brecht Van Lommel (brecht) created this revision.

Brecht Van Lommel (brecht) added a child revision: D8012: Cycles: remove SIMD BVH optimizations, to be replaced by Embree.

Harbormaster completed remote builds in B8528: Diff 25851.Jun 12 2020, 10:52 PM

Just to make it clear: those options were purely development-only. There is no performance impact for none of the kernels (even with OpenCL's feature adaptive kernel compilation which never disabled instancing).

This revision is now accepted and ready to land.Jun 17 2020, 2:58 PM

Closed by commit rB1de0e13af619: Cycles: remove __UV__ and __INSTANCING__ as kernel options (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 22 2020, 1:31 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB1de0e13af619: Cycles: remove __UV__ and __INSTANCING__ as kernel options.

Brecht Van Lommel (brecht) added a commit: rC7ccace12313d: Remove __uv__ and __instancing__ as kernel options.Sep 1 2020, 1:49 AM