Differential D8012

Cycles: remove SIMD BVH optimizations, to be replaced by Embree
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 12 2020, 10:49 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Group Reviewers

Cycles

Maniphest Tasks

T73778: Cycles: Embree improvements

Commits

rCb2f6addcb0e8: Remove simd bvh optimizations, to be replaced by Embree
rBd1ef5146d72d: Cycles: remove SIMD BVH optimizations, to be replaced by Embree

Summary

Ref T73778

Depends on D8011

Diff Detail

Repository

rB Blender

Build Status

Buildable 8529
Build 8529: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jun 12 2020, 10:49 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B8529: Diff 25852.Jun 12 2020, 10:52 PM

Brecht Van Lommel (brecht) added a child revision: D8013: Cycles: port curve-ray intersection from Embree for use in Cycles GPU.Jun 12 2020, 10:55 PM

Generally fine.
Some little comment about BVH_LAYOUT_AUTO we've discussed in person. But I see you're tying the code so it's all fine :)

intern/cycles/kernel/bvh/bvh_local.h
199–207	This extra indirection can be removed now as well. Same applies to all flavours of the traversal.

This revision is now accepted and ready to land.Jun 17 2020, 3:07 PM

Closed by commit rBd1ef5146d72d: Cycles: remove SIMD BVH optimizations, to be replaced by Embree (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 22 2020, 1:31 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBd1ef5146d72d: Cycles: remove SIMD BVH optimizations, to be replaced by Embree.

Brecht Van Lommel (brecht) added a commit: rCb2f6addcb0e8: Remove simd bvh optimizations, to be replaced by Embree.Sep 1 2020, 1:49 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

blender/

addon/

properties.py

11 lines

ui.py

16 lines

blender_sync.cpp

10 lines

bvh/

4 lines

2 lines

63 lines

device/

11 lines

kernel/

CMakeLists.txt

12 lines

bvh/

8 lines

63 lines

145 lines

87 lines

118 lines

2 lines

89 lines

89 lines

geom/

geom_curve_intersect.h

138 lines

geom_motion_curve.h

84 lines

geom_object.h

80 lines

geom_triangle_intersect.h

427 lines

kernel_types.h

12 lines

util/

util_debug.h

6 lines

util_debug.cpp

15 lines

Diff 25852

View Options

intern/cycles/blender/addon/properties.py

View Options

intern/cycles/blender/addon/ui.py

View Options

intern/cycles/blender/blender_sync.cpp

View Options

intern/cycles/bvh/CMakeLists.txt

View Options

intern/cycles/bvh/bvh.h

View Options

intern/cycles/bvh/bvh.cpp

View Options

intern/cycles/bvh/bvh4.h

View Options

intern/cycles/bvh/bvh4.cpp

View Options

intern/cycles/bvh/bvh8.h

View Options

intern/cycles/bvh/bvh8.cpp

View Options

intern/cycles/device/device_cpu.cpp

View Options

intern/cycles/kernel/CMakeLists.txt

View Options

intern/cycles/kernel/bvh/bvh.h

View Options

intern/cycles/kernel/bvh/bvh_local.h

View Options

intern/cycles/kernel/bvh/bvh_nodes.h

View Options

intern/cycles/kernel/bvh/bvh_shadow_all.h

View Options

intern/cycles/kernel/bvh/bvh_traversal.h

View Options

intern/cycles/kernel/bvh/bvh_types.h

View Options

intern/cycles/kernel/bvh/bvh_volume.h

View Options

intern/cycles/kernel/bvh/bvh_volume_all.h

View Options

intern/cycles/kernel/bvh/obvh_local.h

View Options

intern/cycles/kernel/bvh/obvh_nodes.h

View Options

intern/cycles/kernel/bvh/obvh_shadow_all.h

View Options

intern/cycles/kernel/bvh/obvh_traversal.h

View Options

intern/cycles/kernel/bvh/obvh_volume.h

View Options

intern/cycles/kernel/bvh/obvh_volume_all.h

View Options

intern/cycles/kernel/bvh/qbvh_local.h

View Options

intern/cycles/kernel/bvh/qbvh_nodes.h

View Options

intern/cycles/kernel/bvh/qbvh_shadow_all.h

View Options

intern/cycles/kernel/bvh/qbvh_traversal.h

View Options

intern/cycles/kernel/bvh/qbvh_volume.h

View Options

intern/cycles/kernel/bvh/qbvh_volume_all.h

View Options

intern/cycles/kernel/geom/geom_curve_intersect.h

View Options

intern/cycles/kernel/geom/geom_motion_curve.h

View Options

intern/cycles/kernel/geom/geom_object.h

View Options

intern/cycles/kernel/geom/geom_triangle_intersect.h

View Options

intern/cycles/kernel/kernel_types.h

View Options

intern/cycles/util/util_debug.h

View Options

intern/cycles/util/util_debug.cpp

Cycles: remove SIMD BVH optimizations, to be replaced by EmbreeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25852

intern/cycles/blender/addon/properties.py

intern/cycles/blender/addon/ui.py

intern/cycles/blender/blender_sync.cpp

intern/cycles/bvh/CMakeLists.txt

intern/cycles/bvh/bvh.h

intern/cycles/bvh/bvh.cpp

intern/cycles/bvh/bvh4.h

intern/cycles/bvh/bvh4.cpp

intern/cycles/bvh/bvh8.h

intern/cycles/bvh/bvh8.cpp

intern/cycles/device/device_cpu.cpp

intern/cycles/kernel/CMakeLists.txt

intern/cycles/kernel/bvh/bvh.h

intern/cycles/kernel/bvh/bvh_local.h

intern/cycles/kernel/bvh/bvh_nodes.h

intern/cycles/kernel/bvh/bvh_shadow_all.h

intern/cycles/kernel/bvh/bvh_traversal.h

intern/cycles/kernel/bvh/bvh_types.h

intern/cycles/kernel/bvh/bvh_volume.h

intern/cycles/kernel/bvh/bvh_volume_all.h

intern/cycles/kernel/bvh/obvh_local.h

intern/cycles/kernel/bvh/obvh_nodes.h

intern/cycles/kernel/bvh/obvh_shadow_all.h

intern/cycles/kernel/bvh/obvh_traversal.h

intern/cycles/kernel/bvh/obvh_volume.h

intern/cycles/kernel/bvh/obvh_volume_all.h

intern/cycles/kernel/bvh/qbvh_local.h

intern/cycles/kernel/bvh/qbvh_nodes.h

intern/cycles/kernel/bvh/qbvh_shadow_all.h

intern/cycles/kernel/bvh/qbvh_traversal.h

intern/cycles/kernel/bvh/qbvh_volume.h

intern/cycles/kernel/bvh/qbvh_volume_all.h

intern/cycles/kernel/geom/geom_curve_intersect.h

intern/cycles/kernel/geom/geom_motion_curve.h

intern/cycles/kernel/geom/geom_object.h

intern/cycles/kernel/geom/geom_triangle_intersect.h

intern/cycles/kernel/kernel_types.h

intern/cycles/util/util_debug.h

intern/cycles/util/util_debug.cpp

Cycles: remove SIMD BVH optimizations, to be replaced by Embree
ClosedPublic
Actions

Revision Contents
Changeset List