Differential D8014

Cycles: internal refactoring to make thick/ribbon curve separate primitives
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 12 2020, 10:56 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Group Reviewers

Cycles

Maniphest Tasks

T73778: Cycles: Embree improvements

Commits

rC617955c16eaf: Internal refactoring to make thick/ribbon curve separate primitives
rB2c41c8e94fa8: Cycles: internal refactoring to make thick/ribbon curve separate primitives

Summary

Also removing the curve system manager which only stored a few curve intersection
settings. These are all changes towards making shape and subdivision settings
per-object instead of per-scene, but there is more work to do here.

Ref T73778

Depends on D8013

Diff Detail

Repository

rB Blender

Build Status

Buildable 8531
Build 8531: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) created this revision.Jun 12 2020, 10:56 PM

Harbormaster completed remote builds in B8531: Diff 25854.Jun 12 2020, 10:56 PM

Brecht Van Lommel (brecht) requested review of this revision.Jun 12 2020, 10:56 PM

Brecht Van Lommel (brecht) added a child revision: D8015: Cycles: enable Embree by default for CPU rendering.

Sergey Sharybin (sergey) accepted this revision.Jun 17 2020, 3:36 PM

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Sergey Sharybin (sergey) added inline comments.

intern/cycles/bvh/bvh_unaligned.cpp
97	The answer is yes. The reason is because with moving segments in practice is rare when alignment is good enough to give faster results then AABB node, especially when the motion blur is substational. It is possible to calculate OBB for each step and interpolate them for better results, but this is tricky to do with the current code base, and ideally we should use Embree's builder because it gives better locality of curve segments (and it takes care of OBB as well! :)

This revision is now accepted and ready to land.Jun 17 2020, 3:36 PM

Closed by commit rB2c41c8e94fa8: Cycles: internal refactoring to make thick/ribbon curve separate primitives (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 22 2020, 1:31 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB2c41c8e94fa8: Cycles: internal refactoring to make thick/ribbon curve separate primitives.

Brecht Van Lommel (brecht) added a commit: rC617955c16eaf: Internal refactoring to make thick/ribbon curve separate primitives.Sep 1 2020, 1:49 AM