Page MenuHome
Differential D8015

Cycles: enable Embree by default for CPU rendering
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 12 2020, 10:57 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Group Reviewers
Cycles
Maniphest Tasks
T73778: Cycles: Embree improvements
Commits
rCa5a82369de54: Enable embree by default for cpu rendering
rB99436acde8fb: Cycles: enable Embree by default for CPU rendering
Summary

For GPU debugging purposes, it is still possible to render with the same BVH2
on the CPU using the Debug panel in the render properties.

Ref T73778

Depends on D8014

Diff Detail

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jun 12 2020, 10:57 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B8532: Diff 25855.Jun 12 2020, 10:59 PM
Jeroen Bakker (jbakker) awarded a token.Jun 13 2020, 8:28 AM
Alaska (Alaska) awarded a token.Jun 13 2020, 10:53 AM
Alaska (Alaska) added a subscriber: Alaska (Alaska).
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Jun 17 2020, 3:39 PM

I would love to see comparison table between BVH8 vs. Embree to show performance improvement.

The code side looks good to me.

Sergey Sharybin (sergey) accepted this revision.Jun 17 2020, 3:39 PM
This revision is now accepted and ready to land.Jun 17 2020, 3:39 PM
Stefan Werner (swerner) added a subscriber: Stefan Werner (swerner).EditedJun 18 2020, 11:42 AM

Embree vs BVH8 on an Intel CPU
Blender 2.90 (099d47f8a310ca6b89adb4e61cc7ec15cc9c11d9)
Ubuntu 18.04, gcc 7.5.0

EmbreeBVH8
Barbershop7:12 (2600MB)7:07 (2189MB)
BMW1:48 (145MB)1:42 (142MB)
Classroom4:57 (321MB)5:08 (289MB)
Fishy Cat2:20 (558MB)2:37 (795MB)
Koro3:17 (390MB)4:21 (523MB)
Pavillon5:11 (156MB)5:30 (146MB)
Victor8:51 (7060MB)11:27 (8012MB)
Stefan Werner (swerner) added a comment.EditedJun 18 2020, 1:24 PM

The real big speedups come with motion blur. Taking the scene from the blog entry about the Agent 327 motion blur improvements (https://cloud.blender.org/blog/cycles-turbocharged-how-we-made-rendering-10x-faster), frame 105:

EmbreeBVH8 (5 motion steps)
Time5m00s54m15s
Memory6778MB7987MB
Brecht Van Lommel (brecht) added a comment.Jun 18 2020, 2:09 PM

Thanks for the stats! They look ok, I guess we can improve memory usage still by not storing some geometry duplicated.

Closed by commit rB99436acde8fb: Cycles: enable Embree by default for CPU rendering (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 22 2020, 1:33 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB99436acde8fb: Cycles: enable Embree by default for CPU rendering.
Brecht Van Lommel (brecht) added a commit: rCa5a82369de54: Enable embree by default for cpu rendering.Sep 1 2020, 1:49 AM

Revision Contents
Changeset List

PathSize
2 lines
intern/
cycles/
blender/
addon/
15 lines
5 lines
kernel/
2 lines

Diff 25855

View Options

CMakeLists.txt

Loading...
View Options

intern/cycles/blender/addon/properties.py

Loading...
View Options

intern/cycles/blender/blender_sync.cpp

Loading...
View Options

intern/cycles/kernel/kernel_types.h

Loading...