Page MenuHome
Differential D8016

Extrude Manifold Icon
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jun 13 2020, 2:22 AM.

Details

Reviewers
William Reynish (billreynish)
Brecht Van Lommel (brecht)
Group Reviewers
User Interface
Modeling
Commits
rBff0df7c546d7: UI: Add Extrude Manifold Icon
Summary

As explained in T75913, 1 essential items still need to be resolved
before we consider the Extrude Manifold tool ready for release:

  • Icon

This patch proposes this icon:

Here the file with the icon:

icon_geom.blend15 MBDownload

Diff Detail

Repository
rB Blender
Branch
arcpatch-D8016 (branched from master)
Build Status
Buildable 8540
Build 8540: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jun 13 2020, 2:22 AM
Harbormaster completed remote builds in B8534: Diff 25860.Jun 13 2020, 2:22 AM
Germano Cavalcante (mano-wii) requested review of this revision.Jun 13 2020, 2:22 AM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jun 13 2020, 2:28 AM
Andrei Nadin (AnadinX) awarded a token.Jun 13 2020, 7:28 AM
Arian (14AUDDIN) awarded a token.Jun 13 2020, 2:18 PM
William Reynish (billreynish) requested changes to this revision.Jun 13 2020, 10:07 PM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).

LGTM, and the icon is quite nice. Only issue is that it is using a slightly different material with a slightly different variant of green.

Rather nitpicky, but for the other icons there is a small gap where the white lines and the highlighted areas meet. Here I added such a gap:

We could also perhaps make the green negative insert larger, since it's the main focus? Maybe like so?

This revision now requires changes to proceed.Jun 13 2020, 10:07 PM
Ugo Santana (ugosantana) awarded a token.Jun 14 2020, 1:06 AM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jun 14 2020, 10:55 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 25895.Jun 14 2020, 10:56 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)
  • Follow color and line convention on the icon.

    (Updated description)
Harbormaster completed remote builds in B8540: Diff 25895.Jun 14 2020, 10:57 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jun 14 2020, 10:58 PM
Brecht Van Lommel (brecht) accepted this revision as: Brecht Van Lommel (brecht).Jun 15 2020, 4:59 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jun 22 2020, 1:10 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 26166.Jun 22 2020, 2:32 PM
Harbormaster completed remote builds in B8661: Diff 26166.Jun 22 2020, 2:32 PM
Germano Cavalcante (mano-wii) retitled this revision from Extrude, Dissolve and Intersect: Rename to 'Extrude Manifold' and add icon to Extrude Manifold Icon.Jun 22 2020, 2:33 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2020, 4:33 PM
Closed by commit rBff0df7c546d7: UI: Add Extrude Manifold Icon (authored by Germano Cavalcante (mano-wii)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rBff0df7c546d7: UI: Add Extrude Manifold Icon.

Revision Contents
Changeset List

PathSize
release/
datafiles/
icons/
scripts/
presets/
keyconfig/
keymap_data/
8 lines
startup/
bl_operators/
2 lines
bl_ui/
10 lines
source/
blender/
editors/
datafiles/
1 line
mesh/
4 lines

Diff 25895

View Options

release/datafiles/icons/ops.mesh.extrude_manifold.dat

Loading...
View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...
View Options

release/scripts/startup/bl_operators/view3d.py

Loading...
View Options

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py

Loading...
View Options

source/blender/editors/datafiles/CMakeLists.txt

Loading...
View Options

source/blender/editors/mesh/mesh_ops.c

Loading...