Differential D801
Freestyle: remove old and unused stroke shaders Authored by Folkert de Vries (flokkievids) on Sep 26 2014, 4:10 PM. Tags Subscribers None
Details This patch removes some cpp Freestyle shaders that are unused and don't serve a real purpose any more. The removed shaders are:
and a few more that weren't even exposed to the Python api.
Diff Detail Event TimelineComment Actions Thank you @Folkert de Vries (flokkievids) for the revision. I made a few inline notes below. Also could you please revert the removal of ColorNoiseShader? I just remembered a feature request for a thickness noise shader. That could be implemented in a generic form commonly applicable to not only thickness but also color and alpha transparency (as in other color/alpha/thickness shaders). Then the existing ColorNoiseShader can be a basis of the implementation of the requested feature.
Comment Actions The ThicknessNoiseShader is still present, I thought/think it would be a good idea to expose it to python. As for the ColorNoiseShader, would it not be a better idea to use stroke textures for this purpose? That approach provides much more control already, as well as extra features (live preview, color and alpha combined). Comment Actions A thickness noise modifier is a feature requested several times, so let us add one in the 2.73 release. Color, alpha and thickness modifiers of line styles have symmetry such that the same modifier is available for all the three line properties (an exception is the calligraphic shader which is only applicable to thickness). It is true that textures can be used for adding noise to color and alpha, but I feel like it makes sense to have symmetric color/alpha noise shaders in addition to ThicknessNoiseShader. Comment Actions
| ||||||||||||