Page MenuHome
Differential D8023

Fix build with Clang on Linux
ClosedPublic
Actions

Authored by Stefano Bonicatti (smjert) on Jun 15 2020, 3:01 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB59b523c3c98e: Fix build with USD, Clang and Linux
Summary

Building Blender using Clang on Linux
ends up with a linker error when linking USD,
specifically "/usr/bin/ld: -f may not be used without -shared".
This is because USD is linked with "-Wl,-force_load <lib>"
which is unsupported on Linux by ld or lld and
it's only supported on macOS.

Use "-Wl,--whole-archive <lib> -Wl,--no-whole-archive" instead,
and also link TBB libraries.

Diff Detail

Repository
rB Blender

Event Timeline

Stefano Bonicatti (smjert) requested review of this revision.Jun 15 2020, 3:01 AM
Stefano Bonicatti (smjert) created this revision.
Harbormaster completed remote builds in B8541: Diff 25899.Jun 15 2020, 3:01 AM
Brecht Van Lommel (brecht) updated this revision to Diff 26102.Jun 19 2020, 3:41 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Simplify code, to clarify that the important distinction for linker flags is not between Clang and GCC, but macOS and Linux.

Brecht Van Lommel (brecht) accepted this revision.Jun 19 2020, 3:42 PM
This revision is now accepted and ready to land.Jun 19 2020, 3:42 PM
Harbormaster completed remote builds in B8637: Diff 26102.Jun 19 2020, 3:42 PM
Closed by commit rB59b523c3c98e: Fix build with USD, Clang and Linux (authored by Stefano Bonicatti (smjert), committed by Brecht Van Lommel (brecht)). · Explain WhyJun 19 2020, 3:53 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB59b523c3c98e: Fix build with USD, Clang and Linux.

Revision Contents
Changeset List

PathSize
source/
blender/
io/
usd/
6 lines

Diff 26105

View Options

source/blender/io/usd/CMakeLists.txt

Loading...