Page MenuHome

Sculpt: Option to not modify hidden Face Sets in Face Sets Edit
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Jun 15 2020, 4:47 PM.

Details

Summary

This options allows to perform Face Sets operations while preserving the
mesh visibility. Edit hidden face sets is enabled by default in order to
expand the visible area of the mesh with the grow/shrink operator, but
this can be changed in the keymap per edit operation as more operations
are supported.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jun 15 2020, 4:47 PM
Pablo Dobarro (pablodp606) created this revision.
Sergey Sharybin (sergey) requested changes to this revision.Jun 17 2020, 2:23 PM

Ability to edit something what is not visible brings a flag to me. Note that this isn't something we do anywhere else in Blender.
Can you give some workflow examples? This might be fine, but need to know details. Also adding Julian here.

source/blender/editors/sculpt_paint/sculpt_face_set.c
1007–1008

Seems this should be const. Would help to easier understand whats going on.

1022–1023

Use continue,

1022–1023

Seems this is unnecessarily is in the inner loop and can be moved to the outer-most loop.

1036–1052

Same as above.

This revision now requires changes to proceed.Jun 17 2020, 2:23 PM
Pablo Dobarro (pablodp606) marked 4 inline comments as done.
  • Review Update

This was requested by @Julien Kaspar (JulienKaspar). If modify_hidden is enabled it works like in D7367, which means that the ID and visibility of the neighbor hidden face sets is modified to expand the visible area with partially hidden meshes. When modify_hidden is disabled, hidden face sets work like a mask, so it only expands the ID over visible face sets

From the code it seems fine.
The user interaction i'd leave to Julian :)

This revision is now accepted and ready to land.Jun 18 2020, 7:26 PM

The problem I see here (which can be improved in a later patch) is that is an operator property that can only be changed in the keymap because most sculpt operators use shortcuts as they need the mouse cursor position and the redo panel is not available. So it is more like a hidden feature/preference