Page MenuHome
Differential D803

Update lzo library due to security issue
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Sep 27 2014, 6:34 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rBSe1afaa02bfa8: Fix T41974: blender ships vulnerable minilzo version
rB3f802657a24a: Fix T41974: blender ships vulnerable minilzo version
rBe1afaa02bfa8: Fix T41974: blender ships vulnerable minilzo version
Summary

Update lzo to latest version. This fixes a security issue (reported in T41974)

Diff Detail

Repository
rB Blender

Event Timeline

Kévin Dietrich (kevindietrich) updated this revision to Diff 2624.Sep 27 2014, 6:34 PM
Kévin Dietrich (kevindietrich) retitled this revision from to Update lzo library due to security issue.
Kévin Dietrich (kevindietrich) updated this object.
Kévin Dietrich (kevindietrich) added a reviewer: Sergey Sharybin (sergey).
Kévin Dietrich (kevindietrich) planned changes to this revision.Sep 27 2014, 6:47 PM

Apparently, this doesn't compile out of the box. I forgot to test it with the appropriate build flags turned on, will update.

Kévin Dietrich (kevindietrich) updated this revision to Diff 2626.Sep 27 2014, 7:06 PM
  • fix compile issue
Kévin Dietrich (kevindietrich) updated this revision to Diff 2627.Sep 27 2014, 7:36 PM
  • Small correction to previous commit
Sergey Sharybin (sergey) accepted this revision.Sep 27 2014, 9:11 PM
Sergey Sharybin (sergey) edited edge metadata.
Sergey Sharybin (sergey) added subscribers: Martijn Berger (juicyfruit), Thomas Dinges (dingto), jens verwiebe (jensverwiebe).

Seems all good for me.

@Thomas Dinges (dingto), @Martijn Berger (juicyfruit), @jens verwiebe (jensverwiebe) want to check compilability before i land this to git? :)

This revision is now accepted and ready to land.Sep 27 2014, 9:11 PM
jens verwiebe (jensverwiebe) added a comment.Sep 27 2014, 9:28 PM

Tested on OSX:

  • patch applied fine without any offset
  • compile went flawless
  • tested particle pointcache with heavy setting: o.k.

Result: +1

Jens

Thomas Dinges (dingto) added a comment.Sep 27 2014, 9:45 PM

Compilation on Windows is fine with msvc 2013.

Closed by commit rBe1afaa02bfa8: Fix T41974: blender ships vulnerable minilzo version (authored by Kévin Dietrich (kevindietrich), committed by Sergey Sharybin (sergey)).Sep 27 2014, 9:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
extern/
lzo/
minilzo/
9 lines
216 lines
2450 lines
26 lines
4204 lines
source/
blender/
blenkernel/
intern/
7 lines

Diff 2628

View Options

extern/lzo/minilzo/README.LZO

Loading...
View Options

extern/lzo/minilzo/lzoconf.h

Loading...
View Options

extern/lzo/minilzo/lzodefs.h

Loading...
View Options

extern/lzo/minilzo/minilzo.h

Loading...
View Options

extern/lzo/minilzo/minilzo.c

Loading...
View Options

source/blender/blenkernel/intern/pointcache.c

Loading...