Page MenuHome

UI: Ctrl-click on panel header to expand & collapse subpanels
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jun 16 2020, 5:00 AM.

Details

Summary

If the panel is already open and you control click on its header, this patch expands / collapses its subpanels instead of toggling the
expansion for all other panels. If you're toggling a panel's expansion it's already in view anyway, so there is no need to collapse the
other panels in this case anyway.

This helps to address feedback that the properties in the new subpanels for modifiers are hard to access.

Diff Detail

Repository
rB Blender
Branch
panel-ctrl-click-open-subpanels (branched from master)
Build Status
Buildable 8570
Build 8570: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 16 2020, 5:00 AM
Hans Goudey (HooglyBoogly) created this revision.

Looking at video, I think that would make sense to have same solo mode for subpanels of a modifier.
For instance, if user do a Ctrl click on expand icon of a Object Offset subpanel of Array modifier ; that should close Relative Offset subpanel.

Debuk (Debuk) added a subscriber: Debuk (Debuk).EditedJun 16 2020, 11:32 AM

A user preference setting would be nice that swaps the behaviour of ctrl clicks and simple clicks completely.

This revision is now accepted and ready to land.Jun 16 2020, 12:22 PM
Julian Eisel (Severin) accepted this revision.

Accepting as UI team too, since Pablo formally accepted and we agreed on having this in the UI meeting yesterday.

Looking at video, I think that would make sense to have same solo mode for subpanels of a modifier.
For instance, if user do a Ctrl click on expand icon of a Object Offset subpanel of Array modifier ; that should close Relative Offset subpanel.

Good point. The code isn't really set up this way, so it's out of scope for this patch. But I'll try to remember to make this consistent in a future commit.

A user preference setting would be nice that swaps the behaviour of ctrl clicks and simple clicks completely.

In my opinion this is pretty far below the threshold for adding a new preference.

Debuk (Debuk) added a comment.EditedJun 17 2020, 11:42 PM

That's disappointing. I didn't know that there's a well defined threshold for that and hard to believe while looking at all these color values for themes in the prefs. The reason why I brought that up, was because there are quite some people who argued for a more compact layout for modifiers, like the modfiers addon, with a single modifier visible at a time. And with an option for the default behaviour to collapse all modifiers except the most recent unfolded one, you would have made a step to bring those back in. The people on devtalk are just representative for more users with that kind of preference.

This comment was removed by Debuk (Debuk).