Differential D8043

Fix T73892: EEVEE Viewport Render Ignores Render As Wire
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 16 2020, 8:33 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T73892: Wired objects get rendered as solid using "Viewport render image" if the viewport's shading type is "Rendered"

Commits

rB0baa000b85c6: Fix T73892: EEVEE Viewport Render Ignores Render As Wire

Summary

In the viewport an object can be set to be displayed as wire. When
rendering the viewport this setting is ignored and follows the
path or doing a final render. This patch will add an exception
when rendering a viewport render.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 16 2020, 8:33 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B8571: Diff 25961.Jun 16 2020, 8:33 AM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Jun 16 2020, 8:34 AM

Jeroen Bakker (jbakker) added projects: GPU / Viewport, BF Blender (2.90).

We already have a function to check if final render vs opengl render.

This revision now requires changes to proceed.Jun 16 2020, 11:00 AM

Call function

Harbormaster completed remote builds in B8584: Diff 25978.Jun 16 2020, 2:46 PM

We might want to go over all references are use this function in stead.

Jeroen Bakker (jbakker) planned changes to this revision.Jun 16 2020, 3:01 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/draw/engines/eevee/eevee_materials.c
858	Or should we just use DRW_state_is_scene_render()

Use DRW_state_is_scene_render

Harbormaster completed remote builds in B8585: Diff 25979.Jun 16 2020, 3:03 PM

Clément Foucault (fclem) accepted this revision.Jun 28 2020, 2:13 AM

This revision is now accepted and ready to land.Jun 28 2020, 2:13 AM

Closed by commit rB0baa000b85c6: Fix T73892: EEVEE Viewport Render Ignores Render As Wire (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 29 2020, 8:20 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB0baa000b85c6: Fix T73892: EEVEE Viewport Render Ignores Render As Wire.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

eevee/

eevee_materials.c

3 lines

Diff 26350

View Options

source/blender/draw/engines/eevee/eevee_materials.c

Fix T73892: EEVEE Viewport Render Ignores Render As WireClosedPublicActions