Play rendered anim: cleanup and add DJV2
ClosedPublic
Actions

Authored by Damien Picard (pioverfour) on Jun 17 2020, 12:57 PM.

Details

Reviewers

Summary

Hi,
a new version of the DJV sequence player was recently published. This patch enables support for the binary name and command line arguments of this new version, which aren’t compatible with previous versions 1.3.X.
However the author stated on DJV’s repo that it would be better for the two versions to be supported for now since some features were removed from the new version series, so this patch includes a proposition to support both, under DJV and DJV2.

This patch also does a bit of cleanup:

update the DJV macOS path;
remove Framecycler and Blender 2.4: I searched for Framecycler online but couldn’t find any info more recent than 2001, when it was bought by Adobe. I strongly suspect it was discontinued. Blender 2.4 doesn’t seem very likely to be used either any more, and can’t be selected anyway;
remove Boost workaround to T32350 from 2012;
upcase RV and DJV.

Diff Detail

Repository: rB Blender

Event Timeline

Damien Picard (pioverfour) requested review of this revision.Jun 17 2020, 12:57 PM

Damien Picard (pioverfour) created this revision.

Campbell Barton (campbellbarton) mentioned this in rBc877c3b8f65c: Cleanup: remove workaround for boost 1.46.Jun 22 2020, 1:50 PM

Committed:

Replaced DJV v1, since there have been multiple v2 releases, if we're going to support multiple versions of the same application I'd rather have a separate version setting, although I'm not sure it's needed in this case.

This revision is now accepted and ready to land.Jun 22 2020, 1:52 PM

Campbell Barton (campbellbarton) closed this revision.Jun 22 2020, 1:53 PM