Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Animation & Rigging

Maniphest Tasks

T75124: ActionEditor: Keyframes Drawing

Commits

rBbbb2e0614fc3: Performance: Draw play head as an overlay

Summary

When playing back animations a playhead is updated in all the animation editors.
The drawing of the playhead is part of the drawing of the main region RGN_TYPE_WINDOW that redraws the whole region.

This change will draw the play head and window scrollers when updating the screen. This affects the Action editor, Timeline, Graph editor, NLA editor and Sequence editor. There is noticeable speedup when using complex animation files.

Spring 02_020_A.anim.blend fps went from 11.8 to 12.5 when showing a timeline and a action editor on a Ryzen 1700.

This patch relates to D8073 as drawing channel region adds a RGN_DRAW_NO_REBUILD to the RGN_TYPE_WINDOW.

Functional changes

When playing back animation the markers don't jump up/down when near the frame. This could be added back.

TODO after commit

The NLA editor is redrawn on frame change. But doesn't have to. The cause of this isn't animation playback. it could have been the channel region. Need to retest.
Rename region->do_draw_overlay to region->do_draw_paint_cursor to remove naming conflict with draw_overlay

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 18 2020, 4:34 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B8618: Diff 26065.Jun 18 2020, 4:35 PM

drawing of all play heads in an display overlay

Harbormaster completed remote builds in B8632: Diff 26095.Jun 19 2020, 12:46 PM

Jeroen Bakker (jbakker) retitled this revision from [WIP] Fix T75124: Draw action editor current frame as cursor to Performance: Draw play head as an overlay.Jun 19 2020, 12:59 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Animation & Rigging, Brecht Van Lommel (brecht).

Jeroen Bakker (jbakker) added projects: Performance, Animation & Rigging.

Jeroen Bakker (jbakker) added a parent revision: D8073: Performance: Never draw channels region during playback.Jun 19 2020, 2:40 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Fixed follow time

Harbormaster completed remote builds in B8634: Diff 26098.Jun 19 2020, 2:44 PM

Jeroen Bakker (jbakker) planned changes to this revision.Jun 19 2020, 3:03 PM

This comment was removed by Jeroen Bakker (jbakker).

Updated with latest master

Harbormaster completed remote builds in B8636: Diff 26101.Jun 19 2020, 3:08 PM

Jeroen Bakker (jbakker) mentioned this in D8076: Refactoring: View2DScrollers memory allocation.Jun 19 2020, 3:41 PM

Stanislav Ovcharov (Stan1) added a subscriber: Stanislav Ovcharov (Stan1).Jun 19 2020, 4:12 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 19 2020, 4:18 PM

Demeter Dzadik (Mets) awarded a token.Jun 19 2020, 5:01 PM

Demeter Dzadik (Mets) added a subscriber: Demeter Dzadik (Mets).

Seems generally fine.

source/blender/blenkernel/BKE_screen.h
146	This could be named `draw_overlay`, for consistent terminology with `region->do_draw_overlay` which has the same purpose. This term of course has a different meaning in the 3D viewport, but maybe that's ok.
source/blender/windowmanager/intern/wm_draw.c
776–788	Maybe merge this in the paint cursors loop below. Also for paint cursors there is `wmWindowViewport` to reset the OpenGL viewport to the whole window. I would guess this is needed for the `draw_display` case as well.

Brecht Van Lommel (brecht) requested changes to this revision.Jun 19 2020, 5:19 PM

This revision now requires changes to proceed.Jun 19 2020, 5:19 PM

Likkez (Likkez) added a subscriber: Likkez (Likkez).Jun 20 2020, 3:24 PM

Jeroen Bakker (jbakker) mentioned this in rB2fdca5bd1981: Refactoring: View2DScrollers memory allocation.Jun 22 2020, 9:47 PM

Code review + rebase with master

renamed draw_display to draw_overlay
merged draw loop with paint cursor.

Harbormaster completed remote builds in B8677: Diff 26190.Jun 23 2020, 8:50 AM

updated draw_overlay comment

Harbormaster completed remote builds in B8678: Diff 26191.Jun 23 2020, 8:55 AM

Jeroen Bakker (jbakker) added inline comments.Jun 23 2020, 8:55 AM

source/blender/blenkernel/BKE_screen.h
146	The `region->do_draw_overlay` isn't connected with `draw_overlay` but with `draw_paint_cursor`. IMO we should rename `do_draw_overlay` to `do_draw_paint_cursor` for more consistency in a separate commit.
source/blender/windowmanager/intern/wm_draw.c
776–788	Done, for `draw_overlay` the `wm_region_draw_display` resets the window viewport to its original state. Another `wmWindowViewport` was not needed. This part could be rechecked to reduce gl setup calls that aren't necessary.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 23 2020, 8:57 AM

Brecht Van Lommel (brecht) accepted this revision.Jun 23 2020, 11:32 AM

Brecht Van Lommel (brecht) added inline comments.

source/blender/blenkernel/BKE_screen.h
146	Sounds good.

This revision is now accepted and ready to land.Jun 23 2020, 11:32 AM

Closed by commit rBbbb2e0614fc3: Performance: Draw play head as an overlay (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 23 2020, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBbbb2e0614fc3: Performance: Draw play head as an overlay.

Jeroen Bakker (jbakker) mentioned this in D7174: Fix paint cursor lagging behind the OS cursor.Jun 23 2020, 12:11 PM

Performance: Draw play head as an overlay
ClosedPublic
Actions

Details

Functional changes

TODO after commit

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 26197

source/blender/blenkernel/BKE_screen.h

source/blender/editors/animation/time_scrub_ui.c

source/blender/editors/include/ED_anim_api.h

source/blender/editors/include/ED_time_scrub_ui.h

source/blender/editors/screen/screen_ops.c

source/blender/editors/space_action/space_action.c

source/blender/editors/space_graph/space_graph.c

source/blender/editors/space_nla/space_nla.c

source/blender/editors/space_sequencer/sequencer_draw.c

source/blender/editors/space_sequencer/sequencer_intern.h

source/blender/editors/space_sequencer/space_sequencer.c

source/blender/windowmanager/intern/wm_draw.c

Performance: Draw play head as an overlayClosedPublicActions

Details

Functional changes

TODO after commit

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26197

source/blender/blenkernel/BKE_screen.h

source/blender/editors/animation/time_scrub_ui.c

source/blender/editors/include/ED_anim_api.h

source/blender/editors/include/ED_time_scrub_ui.h

source/blender/editors/screen/screen_ops.c

source/blender/editors/space_action/space_action.c

source/blender/editors/space_graph/space_graph.c

source/blender/editors/space_nla/space_nla.c

source/blender/editors/space_sequencer/sequencer_draw.c

source/blender/editors/space_sequencer/sequencer_intern.h

source/blender/editors/space_sequencer/space_sequencer.c

source/blender/windowmanager/intern/wm_draw.c

Performance: Draw play head as an overlay
ClosedPublic
Actions

Revision Contents
Changeset List